owncloud/core

View on GitHub
lib/private/legacy/response.php

Summary

Maintainability
C
7 hrs
Test Coverage

File response.php has 264 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * @author Andreas Fischer <bantu@owncloud.com>
 * @author Bart Visscher <bartv@thisnet.nl>
 * @author Jörn Friedrich Dreyer <jfd@butonic.de>
Severity: Minor
Found in lib/private/legacy/response.php - About 2 hrs to fix

    Method getAllowedCorsHeaders has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private static function getAllowedCorsHeaders(\OCP\IConfig $config = null) {
            if ($config === null) {
                $config = \OC::$server->getConfig();
            }
            $allowedDefaultHeaders = [
    Severity: Major
    Found in lib/private/legacy/response.php - About 2 hrs to fix

      Method setStatus has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function setStatus($status) {
              $protocol = \OC::$server->getRequest()->getHttpProtocol();
              switch ($status) {
                  case self::STATUS_NOT_MODIFIED:
                      $status = $status . ' Not Modified';
      Severity: Minor
      Found in lib/private/legacy/response.php - About 1 hr to fix

        Function setStatus has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function setStatus($status) {
                $protocol = \OC::$server->getRequest()->getHttpProtocol();
                switch ($status) {
                    case self::STATUS_NOT_MODIFIED:
                        $status = $status . ' Not Modified';
        Severity: Minor
        Found in lib/private/legacy/response.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function setCorsHeaders has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function setCorsHeaders($userId, $domain, \OCP\IConfig $config = null, array $headers = []) {
                if ($config === null) {
                    $config = \OC::$server->getConfig();
                }
                // first check if any of the global CORS domains matches
        Severity: Minor
        Found in lib/private/legacy/response.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status