padrino/padrino-framework

View on GitHub

Showing 214 of 214 total issues

Similar blocks of code found in 9 locations. Consider refactoring.
Open

  $.fn.scrollspy.noConflict = function () {
    $.fn.scrollspy = old
    return this
  }
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/affix.js on lines 114..117
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/alert.js on lines 77..80
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/button.js on lines 91..94
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/carousel.js on lines 173..176
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/collapse.js on lines 142..145
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/dropdown.js on lines 132..135
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/modal.js on lines 215..218
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/tab.js on lines 111..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

  $.fn.modal.noConflict = function () {
    $.fn.modal = old
    return this
  }
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/affix.js on lines 114..117
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/alert.js on lines 77..80
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/button.js on lines 91..94
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/carousel.js on lines 173..176
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/collapse.js on lines 142..145
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/dropdown.js on lines 132..135
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/scrollspy.js on lines 137..140
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/tab.js on lines 111..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        $(this).addClass('list-row-action-wrapper-link-active')
          .siblings('.list-row-action-popover-delete-one').first().show()
          .find('.cancel').on('click', function() {

            $(this).parents('.list-row-action-popover-delete-one').hide()
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/application.js on lines 89..98

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

  $.fn.alert.noConflict = function () {
    $.fn.alert = old
    return this
  }
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/affix.js on lines 114..117
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/button.js on lines 91..94
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/carousel.js on lines 173..176
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/collapse.js on lines 142..145
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/dropdown.js on lines 132..135
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/modal.js on lines 215..218
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/scrollspy.js on lines 137..140
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/tab.js on lines 111..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

  $.fn.carousel.noConflict = function () {
    $.fn.carousel = old
    return this
  }
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/affix.js on lines 114..117
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/alert.js on lines 77..80
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/button.js on lines 91..94
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/collapse.js on lines 142..145
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/dropdown.js on lines 132..135
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/modal.js on lines 215..218
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/scrollspy.js on lines 137..140
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/tab.js on lines 111..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        $(this).addClass('active')
          .siblings('.list-menu-popover-delete-selected').first().show()
          .find('.cancel').on('click', function() {
          
            // Hide the popover on cancel
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/application.js on lines 38..44

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

  $.fn.collapse.noConflict = function () {
    $.fn.collapse = old
    return this
  }
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/affix.js on lines 114..117
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/alert.js on lines 77..80
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/button.js on lines 91..94
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/carousel.js on lines 173..176
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/dropdown.js on lines 132..135
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/modal.js on lines 215..218
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/scrollspy.js on lines 137..140
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/tab.js on lines 111..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

  $.fn.dropdown.noConflict = function () {
    $.fn.dropdown = old
    return this
  }
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/affix.js on lines 114..117
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/alert.js on lines 77..80
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/button.js on lines 91..94
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/carousel.js on lines 173..176
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/collapse.js on lines 142..145
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/modal.js on lines 215..218
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/scrollspy.js on lines 137..140
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/tab.js on lines 111..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

  $.fn.affix.noConflict = function () {
    $.fn.affix = old
    return this
  }
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/alert.js on lines 77..80
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/button.js on lines 91..94
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/carousel.js on lines 173..176
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/collapse.js on lines 142..145
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/dropdown.js on lines 132..135
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/modal.js on lines 215..218
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/scrollspy.js on lines 137..140
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/tab.js on lines 111..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

  $.fn.button.noConflict = function () {
    $.fn.button = old
    return this
  }
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/affix.js on lines 114..117
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/alert.js on lines 77..80
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/carousel.js on lines 173..176
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/collapse.js on lines 142..145
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/dropdown.js on lines 132..135
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/modal.js on lines 215..218
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/scrollspy.js on lines 137..140
padrino-admin/lib/padrino-admin/generators/templates/assets/javascripts/bootstrap/tab.js on lines 111..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method render has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def render(engine=nil, data=nil, options={}, locals={}, &block)
Severity: Minor
Found in padrino-mailer/lib/padrino-mailer/ext.rb - About 35 mins to fix

    Method bench has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def bench(action, began_at, message, level=:debug, color=:yellow)
    Severity: Minor
    Found in padrino-core/lib/padrino-core/logger.rb - About 35 mins to fix

      Method render_like_sinatra has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def render_like_sinatra(engine, data, options={}, locals={}, &block)
      Severity: Minor
      Found in padrino-helpers/lib/padrino/rendering.rb - About 35 mins to fix

        Method render has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

              def render(engine, data=nil, options={}, locals={}, &block)
        Severity: Minor
        Found in padrino-helpers/lib/padrino/rendering.rb - About 35 mins to fix

          Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def initialize(mode, scoped_controller, options, args, &block)
          Severity: Minor
          Found in padrino-core/lib/padrino-core/filter.rb - About 35 mins to fix

            Method drop_db has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                  def self.drop_db(adapter, user, password, host, database)
            Severity: Minor
            Found in padrino-gen/lib/padrino-gen/padrino-tasks/sql-helpers.rb - About 35 mins to fix

              Method move_as has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                def move_as(type)
                  step = ENV['STEP'] ? ENV['STEP'].to_i : 1
              
                  if less_than_active_record_5_2?
                    ActiveRecord::Migrator.send(type, 'db/migrate/', step)
              Severity: Minor
              Found in padrino-gen/lib/padrino-gen/padrino-tasks/activerecord.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method migrate_as has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                def migrate_as(type)
                  version = env_migration_version
                  fail "MIGRATION_VERSION is required" unless version
              
                  if less_than_active_record_5_2?
              Severity: Minor
              Found in padrino-gen/lib/padrino-gen/padrino-tasks/activerecord.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method registered has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                    def registered(app)
                      app.helpers Padrino::Cache::Helpers::ObjectCache
                      app.helpers Padrino::Cache::Helpers::CacheStore
                      app.helpers Padrino::Cache::Helpers::Fragment
                      app.helpers Padrino::Cache::Helpers::Page
              Severity: Minor
              Found in padrino-cache/lib/padrino-cache.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method detect_application has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                def self.detect_application(options)
                  default_config_file = 'config.ru'
                  if (config_file = options.delete(:config)) || File.file?(default_config_file)
                    config_file ||= default_config_file
                    fail "Rack config file `#{config_file}` must have `.ru` extension" unless config_file =~ /\.ru$/
              Severity: Minor
              Found in padrino-core/lib/padrino-core/server.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language