Sign upLogin

padrino/padrino-framework

View on GitHub
Star
padrino-gen/lib/padrino-gen/generators/components/orms/sequel.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method setup_orm has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def setup_orm
  sequel = SEQUEL
  db = @project_name.underscore
  require_dependencies 'sequel'
Severity: Minor
Found in padrino-gen/lib/padrino-gen/generators/components/orms/sequel.rb - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        when 'mysql', 'mysql2'
      sequel.gsub!(/!DB_DEVELOPMENT!/, "\"mysql2://localhost/#{db}_development\"")
      sequel.gsub!(/!DB_PRODUCTION!/, "\"mysql2://localhost/#{db}_production\"")
      sequel.gsub!(/!DB_TEST!/,"\"mysql2://localhost/#{db}_test\"")
      require_dependencies 'mysql2'
    Severity: Minor
    Found in padrino-gen/lib/padrino-gen/generators/components/orms/sequel.rb and 1 other location - About 20 mins to fix
    padrino-gen/lib/padrino-gen/generators/components/orms/datamapper.rb on lines 74..78

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 27.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        when 'postgres'
      sequel.gsub!(/!DB_DEVELOPMENT!/, "\"postgres://localhost/#{db}_development\"")
      sequel.gsub!(/!DB_PRODUCTION!/, "\"postgres://localhost/#{db}_production\"")
      sequel.gsub!(/!DB_TEST!/,"\"postgres://localhost/#{db}_test\"")
      require_dependencies 'pg'
    Severity: Minor
    Found in padrino-gen/lib/padrino-gen/generators/components/orms/sequel.rb and 3 other locations - About 15 mins to fix
    padrino-gen/lib/padrino-gen/generators/components/orms/datamapper.rb on lines 79..83
    padrino-gen/lib/padrino-gen/generators/components/orms/datamapper.rb on lines 84..88
    padrino-gen/lib/padrino-gen/generators/components/orms/sequel.rb on lines 32..36

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 26.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        when 'sqlite'
      sequel.gsub!(/!DB_DEVELOPMENT!/,"\"sqlite://db/#{db}_development.db\"")
      sequel.gsub!(/!DB_PRODUCTION!/, "\"sqlite://db/#{db}_production.db\"")
      sequel.gsub!(/!DB_TEST!/,       "\"sqlite://db/#{db}_test.db\"")
      require_dependencies 'sqlite3'
    Severity: Minor
    Found in padrino-gen/lib/padrino-gen/generators/components/orms/sequel.rb and 3 other locations - About 15 mins to fix
    padrino-gen/lib/padrino-gen/generators/components/orms/datamapper.rb on lines 79..83
    padrino-gen/lib/padrino-gen/generators/components/orms/datamapper.rb on lines 84..88
    padrino-gen/lib/padrino-gen/generators/components/orms/sequel.rb on lines 27..31

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 26.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status