pantuspavel/PPEventRegistryAPI

View on GitHub

Showing 15 of 63 total issues

Function spec has 145 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    override func spec() {

        var api = PPEventRegistryAPI()

        beforeEach {

    Function spec has 111 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        override func spec() {
    
            describe("HttpMethod") {
    
                it ("Get case is in place") {

      Function spec has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
      Open

          override func spec() {
      
              describe("HttpMethod") {
      
                  it ("Get case is in place") {

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function spec has 77 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          override func spec() {
              describe("Initialization") {
      
                  var modelMapper = PPModelMapper()
      
      

        Function spec has 73 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            override func spec() {
        
                describe("Initialization") {
        
                    it("init with value creates success") {

          Function spec has 70 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              override func spec() {
          
                  let params: [String: Any] = ["key1": "arg1", "key2": "arg2"]
                  var asyncOperation = PPAsyncOperation(controller: .Login,
                                                        method: .Get,

            Function spec has 53 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                override func spec() {
            
                    var getRecentArticles = PPRecentArticlesOperation {_ in}
            
                    beforeEach {

              Function fixture1 has 43 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  static func fixture1() -> [String: Any] {
                      return [
                          "info" : [
                              "summary" : [
                                  "eng" : "All Exxon Mobil Corp. had to do is run its Los Angeles-area refinery for 15 days before handing the keys to new owner PBF Energy.\n\nThat's turning into a struggle. More than a month after Exxon Mobil restarted a key gasoline-making unit that was damaged in a blast last year, PBF still hasn't taken control of the Torrance plant. In the latest snag, a crane fell over Monday. While Exxon says it had no effect on production and the handover to PBF is still scheduled for mid year, the incident highligh"

                Function spec has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    override func spec() {
                
                        describe("Equatable") {
                
                            it("errors of the same type are equal") {

                  Function spec has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      override func spec() {
                  
                          var loginOperation = PPLoginOperation(email: "a@b.c",
                                                                password: "q",
                                                                completionHandler: {_ in})

                    Function viewDidLoad has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                        override func viewDidLoad() {
                            if #available(OSX 10.10, *) {
                                super.viewDidLoad()
                            } else {
                                // Fallback on earlier versions
                    Severity: Minor
                    Found in Example/PPEventRegistryTest macOS/ViewController.swift - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function applicationDidFinishLaunching has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        func applicationDidFinishLaunching() {
                            // Perform any final initialization of your application.
                            api.setTransferProtocol(.http)
                            api.login("testeventregistry@gmail.com", password: "cDWTgGpJ4Ny") { error in
                                print("login with error: \(error)")
                    Severity: Minor
                    Found in Example/PPEventRegistryTest watchOS Extension/ExtensionDelegate.swift - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function viewDidLoad has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        override func viewDidLoad() {
                            super.viewDidLoad()
                            api.setTransferProtocol(.https)
                            api.login("testeventregistry@gmail.com", password: "cDWTgGpJ4Ny") { error in
                                print("login with error: \(error)")
                    Severity: Minor
                    Found in Example/PPEventRegistryTest/ViewController.swift - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function viewDidLoad has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        override func viewDidLoad() {
                            super.viewDidLoad()
                            api.setTransferProtocol(.https)
                            api.login("testeventregistry@gmail.com", password: "cDWTgGpJ4Ny") { error in
                                print("login with error: \(error)")
                    Severity: Minor
                    Found in Example/PPEventRegistryTest tvOS/ViewController.swift - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function mapDataToModelObjects has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        func mapDataToModelObjects(_ data: [String: Any]) -> [PPArticle] {
                            var articles: [PPArticle] = []
                            if let recentActivity = data["recentActivity"] as? [String: Any] {
                                if let articlesData = recentActivity["articles"] as? [String: Any] {
                                    if let activity = articlesData["activity"] as? [[String: Any]] {
                    Severity: Minor
                    Found in PPEventRegistryAPI/Classes/Models/PPModelMapper.swift - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language