Sign upLogin

parroit/requesty

View on GitHub
Star

Showing 9 of 9 total issues

Function coreRequest has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
Open

function coreRequest(options, cb) {
    var protocol;
    if (options.scheme.indexOf('https') === 0) {
        protocol = https;
        options.scheme = 'https';
Severity: Minor
Found in lib/core.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function coreRequest has 84 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function coreRequest(options, cb) {
    var protocol;
    if (options.scheme.indexOf('https') === 0) {
        protocol = https;
        options.scheme = 'https';
Severity: Major
Found in lib/core.js - About 3 hrs to fix

    Function send has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    Request.prototype.send = function(body, cb) {
    var opt = this.options;
    if (opt.mode !== 'promises' && opt.mode !== 'callbacks'  && opt.mode !== 'streams') {
        throw new Error('Unknown mode ' + opt.mode);
    }
    Severity: Major
    Found in lib/requesty.js - About 2 hrs to fix

      Function send has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

      Request.prototype.send = function(body, cb) {
    var opt = this.options;
    if (opt.mode !== 'promises' && opt.mode !== 'callbacks'  && opt.mode !== 'streams') {
        throw new Error('Unknown mode ' + opt.mode);
    }
      Severity: Minor
      Found in lib/requesty.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function req has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          var req = protocol.request(options, function(res) {
        if (res.statusCode === 302) {

            var requesty = require('./requesty');
      Severity: Minor
      Found in lib/core.js - About 1 hr to fix

        Function headers has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        Request.prototype.headers = function(name, value) {
    var headers;

    if (typeof name === 'undefined' && typeof value === 'undefined') {
        return this;
        Severity: Minor
        Found in lib/requesty.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        Request.prototype.method = function(methodName, uri) {
    this.options.method = methodName.toUpperCase();
    if (uri) {
        this.using(uri);
    }
        Severity: Minor
        Found in lib/requesty.js and 1 other location - About 35 mins to fix
        lib/requesty.js on lines 115..121

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            Request.prototype[methodName] = function(uri) {
        this.options.method = methodName.toUpperCase();
        if (uri) {
            this.using(uri);
        }
        Severity: Minor
        Found in lib/requesty.js and 1 other location - About 35 mins to fix
        lib/requesty.js on lines 133..139

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function proxy has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        Request.prototype.proxy = function(hostname, user, password) {
    var proxyOptions;

    if (
        typeof hostname === 'object' &&
        Severity: Minor
        Found in lib/requesty.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language