partkeepr/PartKeepr

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (fieldValues.importBehaviour === "matchData") {
            this.down("#importFieldMatcherGrid").enable();
            this.down("#dontUpdateData").enable();
            this.down("#updateData").enable();
        } else {

Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/Importer/ImporterEntityConfiguration.js and 1 other location - About 1 hr to fix

Read up
Read up

src/PartKeepr/FrontendBundle/Resources/public/js/Components/Importer/ImporterEntityConfiguration.js on lines 81..85

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 57.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (this.record.distributors().getCount() < minDistributorCount) {
            errors.push(
                Ext.String.format(i18n("The number of distributors must be greater than {0}"), minDistributorCount));
        }

Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/Part/Editor/PartEditor.js and 1 other location - About 1 hr to fix

Read up
Read up

src/PartKeepr/FrontendBundle/Resources/public/js/Components/Part/Editor/PartEditor.js on lines 393..396

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 57.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Function `initComponent` has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    initComponent: function ()
    {
        this.rendererStore = Ext.create("Ext.data.Store");

        this.columns = [{

Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/Widgets/ColumnConfigurator/RenderersGrid.js - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `selectTheme` has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    selectTheme: function (theme) {
        var i, j, menuItem;

        for (i = 0; i < this.items.getCount(); i++) {
            if (this.items.getAt(i).type === "themes") {

Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/MenuBar.js - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `toIntArray` has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

String.prototype.toIntArray = function() {
  var w1, w2, u, r4 = [], r = [], i = 0;
  var s = this + '\0\0\0'; // pad string to avoid discarding last chars
  var l = s.length - 1;

Found in src/PartKeepr/FrontendBundle/Resources/public/js/Util/Crypto/isaac.js - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `setActiveItem` has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    setActiveItem : function(item){
        item = this.container.getComponent(item);
        if(this.activeItem != item){
            if(this.activeItem){
                this.activeItem.hide();

Found in src/PartKeepr/FrontendBundle/Resources/public/js/Ext.ux.Wizard.CardLayout.js - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `extractJSONSorters` has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    private function extractJSONSorters(
        $data
    ) {
        $sorter = new Sorter();

Found in src/PartKeepr/DoctrineReflectionBundle/Filter/AdvancedSearchFilter.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `import` has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function import($row, $obj = null)
    {
        if ($obj === null) {
            $obj = new $this->baseEntity();
            $this->persist($obj);

Found in src/PartKeepr/ImportBundle/Configuration/Configuration.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `import` has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function import($row, $obj = null)
    {
        $descriptions = [];
        switch ($this->importBehaviour) {
            case self::IMPORTBEHAVIOUR_ALWAYSSETTO:

Found in src/PartKeepr/ImportBundle/Configuration/ManyToOneConfiguration.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `createPicker` has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    createPicker: function ()
    {
        this.fireEvent("beforeSelect", this);

        this.modelFieldSelector = Ext.create({

Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/Widgets/FieldSelectTrigger.js - About 1 hr to fix

Function `initComponent` has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    initComponent: function ()
    {
        console.log(this.markedAsDefaultProperty);
        if (this.allowMarkAsDefault) {
            this.tpl = Ext.create('Ext.XTemplate',

Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/Widgets/PresetComboBox.js - About 1 hr to fix

Function `getProgressBar` has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    getProgressBar: function () {
        var progressbar = Ext.widget('progressbar', {
            value: 0.5
        });

Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/ThemeTester/ThemeTester.js - About 1 hr to fix

Function `reconfigureGrid` has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    reconfigureGrid: function (data)
    {
        var columns = [];
        var fieldConfig = [];
        var header = data[0];

Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/Importer/Importer.js - About 1 hr to fix

Function `getFilterFn` has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

                        getFilterFn: function ()
                        {
                            if (this.partManager !== null) {
                                if (this.categoryFilter.getValue().category === "all") {
                                    if (this.partManager.getSelectedCategory() !== null) {

Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/Part/PartFilterPanel.js - About 1 hr to fix

Function `onAddParameterFilter` has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    onAddParameterFilter: function (rec) {
        var subFilters = [];


        subFilters.push( Ext.create("PartKeepr.util.Filter", {

Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/Part/PartsGrid.js - About 1 hr to fix

Function `createLayout` has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    createLayout: function ()
    {
        this.statusBar = Ext.create("PartKeepr.Statusbar");

        this.messageLog = this.createMessageLog();

Found in src/PartKeepr/FrontendBundle/Resources/public/js/PartKeepr.js - About 1 hr to fix

Method `import` has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function import($row, $obj = null)
    {
        if ($obj === null) {
            $obj = new $this->baseEntity();
            $this->persist($obj);

Found in src/PartKeepr/ImportBundle/Configuration/Configuration.php - About 1 hr to fix

Method `getExtJSFieldMapping` has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function getExtJSFieldMapping($type)
    {
        switch ($type) {
            case 'integer':
                return 'int';

Found in src/PartKeepr/DoctrineReflectionBundle/Services/ReflectionService.php - About 1 hr to fix

Method `import` has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function import($preview = false)
    {
        $entities = [];
        $logs = [];

Found in src/PartKeepr/ImportBundle/Service/ImporterService.php - About 1 hr to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        this.addButton = new Ext.Button({
            text: i18n("Add Stock"),
            iconCls: 'web-icon brick_add',
            handler: Ext.bind(this.addPartStockPrompt, this)
        });

Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/Part/PartDisplay.js and 1 other location - About 1 hr to fix

Read up
Read up

src/PartKeepr/FrontendBundle/Resources/public/js/Components/Part/PartDisplay.js on lines 28..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76