Sign upLogin

partkeepr/PartKeepr

View on GitHub
Star

Showing 922 of 922 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                renderer: function (val, p, rec)
                {
                    if (rec.getManufacturer() !== null) {
                        return rec.getManufacturer().get("name");
                    } else {
Severity: Major
Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/Part/Editor/PartManufacturerGrid.js and 1 other location - About 1 hr to fix
src/PartKeepr/FrontendBundle/Resources/public/js/Components/Part/Editor/PartDistributorGrid.js on lines 55..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        this.dockedItems = [
            {
                xtype: 'toolbar',
                items: [
                    {
Severity: Major
Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/Part/Editor/PartManufacturerGrid.js and 1 other location - About 1 hr to fix
src/PartKeepr/FrontendBundle/Resources/public/js/Components/Part/Editor/PartDistributorGrid.js on lines 37..49

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                renderer: function (val, p, rec)
                {
                    if (rec.getDistributor() !== null) {
                        return rec.getDistributor().get("name");
                    } else {
Severity: Major
Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/Part/Editor/PartDistributorGrid.js and 1 other location - About 1 hr to fix
src/PartKeepr/FrontendBundle/Resources/public/js/Components/Part/Editor/PartManufacturerGrid.js on lines 56..63

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        this.dockedItems = [
            {
                xtype: 'toolbar',
                items: [
                    {
Severity: Major
Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/Part/Editor/PartDistributorGrid.js and 1 other location - About 1 hr to fix
src/PartKeepr/FrontendBundle/Resources/public/js/Components/Part/Editor/PartManufacturerGrid.js on lines 37..49

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        this.deleteButton = new Ext.Button({
            text: i18n("Remove Stock"),
            iconCls: 'web-icon brick_delete',
            handler: Ext.bind(this.removePartStockPrompt, this)
        });
Severity: Major
Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/Part/PartDisplay.js and 1 other location - About 1 hr to fix
src/PartKeepr/FrontendBundle/Resources/public/js/Components/Part/PartDisplay.js on lines 19..23

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function fs_error has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

                , fs_error = function() {
                    if (target_view && is_safari && typeof FileReader !== "undefined") {
                        // Safari doesn't allow downloading of blob urls
                        var reader = new FileReader();
                        reader.onloadend = function() {
Severity: Minor
Found in src/PartKeepr/FrontendBundle/Resources/public/js/Util/FileSaver.js - About 1 hr to fix

    Function SIUnitPrefix has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        SIUnitPrefix: function( q_value, q_unit )
    {
        // the new Octopart API returns quantities as display strings: e.g. "12 mm"
        // try to recognize SI-unit and SI-prefix
    Severity: Minor
    Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/OctoPart/DataApplicator.js - About 1 hr to fix

      Function onSetValueClick has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          onSetValueClick: function (widgetColumn)
    {
        this.editingRecord = widgetColumn.getWidgetRecord();
      Severity: Minor
      Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/BatchJob/BatchJobExecutionWindow.js - About 1 hr to fix

        Function getFramedPanel has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            getFramedPanel: function () {
        return this.applySizing('framedPanel', {
            xtype: 'panel',
            title: 'Framed Panel',
            animCollapse: true,
        Severity: Minor
        Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/ThemeTester/ThemeTester.js - About 1 hr to fix

          Function launch has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              launch: function ()
    {
        Ext.setGlyphFontFamily('FontAwesome');
        Ext.get("loader-wrapper").hide();
        Ext.setLocale('en_US');
          Severity: Minor
          Found in src/PartKeepr/FrontendBundle/Resources/public/js/PartKeepr.js - About 1 hr to fix

            Method testMimeType has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function testMimeType()
    {
        $client = static::makeClient(true);

        $file = __DIR__.'/Fixtures/files/uploadtest.png';
            Severity: Minor
            Found in src/PartKeepr/UploadedFileBundle/Tests/FileControllerTest.php - About 1 hr to fix

              Method testGetFile has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function testGetFile()
    {
        $client = static::makeClient(true);

        $file = __DIR__.'/Fixtures/files/uploadtest.png';
              Severity: Minor
              Found in src/PartKeepr/UploadedFileBundle/Tests/FileControllerTest.php - About 1 hr to fix

                Function initComponent has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    initComponent: function ()
    {
        this.testResultPanel = Ext.create("PartKeeprSetup.TestResultPanel", {
            flex: 1
        });
                Severity: Minor
                Found in web/setup/js/Cards/AbstractTestCard.js - About 1 hr to fix

                  Method replaceFromURL has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function replaceFromURL(UploadedFile $file, $url)
    {
        /* Some sites don't like automated requests. But the internet is meant to be open for anybody,
         * even for scripts. So we are evil and fake the headers.
         *
                  Severity: Minor
                  Found in src/PartKeepr/UploadedFileBundle/Services/UploadedFileService.php - About 1 hr to fix

                    Method getPartByUID has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function getPartByUID($uid)
    {
        try {
            $redisclient = new PredisClient();
            $redisclient->connect();
                    Severity: Minor
                    Found in src/PartKeepr/OctoPartBundle/Services/OctoPartService.php - About 1 hr to fix

                      Method testProjectPartRemoval has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function testProjectPartRemoval()
    {
        $client = static::makeClient(true);

        $project = $this->fixtures->getReference('project');
                      Severity: Minor
                      Found in src/PartKeepr/ProjectBundle/Tests/ProjectTest.php - About 1 hr to fix

                        Function renderer has 8 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            renderer: function (value, metaData, record, rowIndex, colIndex, store, view, renderObj)
                        Severity: Major
                        Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/Grid/Renderers/IconRenderer.js - About 1 hr to fix

                          Function renderer has 8 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              renderer: function (value, metaData, record, rowIndex, colIndex, store, view, renderObj)
                          Severity: Major
                          Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/Grid/Renderers/ObjectFieldRenderer.js - About 1 hr to fix

                            Function renderer has 8 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                renderer: function (value, metaData, record, rowIndex, colIndex, store, view, renderObj)
                            Severity: Major
                            Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/Part/Renderers/PartParameterRenderer.js - About 1 hr to fix

                              Function renderer has 8 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                  renderer: function (value, metaData, record, rowIndex, colIndex, store, view, renderObj)
                              Severity: Major
                              Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/Project/Renderers/ProjectPartParameterRenderer.js - About 1 hr to fix
                                Severity
                                Category
                                Status
                                Source
                                Language