passport-next/passport-google-oauth2

View on GitHub

Showing 5 of 5 total issues

Function userProfile has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

Strategy.prototype.userProfile = function userProfile(accessToken, done) {
  this._oauth2.get(this._userProfileURL, accessToken, (err, body) => {
    let json;

    if (err) {
Severity: Minor
Found in lib/strategy.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function authorizationParams has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Strategy.prototype.authorizationParams = function authorizationParams(options) {
  const params = {};

  // https://developers.google.com/identity/protocols/OAuth2WebServer
  if (options.accessType) {
Severity: Minor
Found in lib/strategy.js - About 1 hr to fix

    Function authorizationParams has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    Strategy.prototype.authorizationParams = function authorizationParams(options) {
      const params = {};
    
      // https://developers.google.com/identity/protocols/OAuth2WebServer
      if (options.accessType) {
    Severity: Minor
    Found in lib/strategy.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function userProfile has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    Strategy.prototype.userProfile = function userProfile(accessToken, done) {
      this._oauth2.get(this._userProfileURL, accessToken, (err, body) => {
        let json;
    
        if (err) {
    Severity: Minor
    Found in lib/strategy.js - About 1 hr to fix

      Function parse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      function parse(json) {
        if (typeof json === 'string') {
          json = JSON.parse(json);
        }
      
      
      Severity: Minor
      Found in lib/profile/openid.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language