patrickfav/bkdf

View on GitHub

Showing 10 of 10 total issues

Method main has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static void main(String args[]) {
        System.out.println("- Downloader started");
        File baseDirectory = new File(args[0]);
        System.out.println("- Using base directory: " + baseDirectory.getAbsolutePath());

Severity: Minor
Found in .mvn/wrapper/MavenWrapperDownloader.java - About 1 hr to fix

    Method main has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        public static void main(String args[]) {
            System.out.println("- Downloader started");
            File baseDirectory = new File(args[0]);
            System.out.println("- Using base directory: " + baseDirectory.getAbsolutePath());
    
    
    Severity: Minor
    Found in .mvn/wrapper/MavenWrapperDownloader.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            @Override
            public boolean equals(Object o) {
                if (this == o) return true;
                if (o == null || getClass() != o.getClass()) return false;
                KdfConfig kdfConfig = (KdfConfig) o;
    src/main/java/at/favre/lib/crypto/bkdf/CompoundHashData.java on lines 177..184

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 70.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            @Override
            public boolean equals(Object o) {
                if (this == o) return true;
                if (o == null || getClass() != o.getClass()) return false;
                Config that = (Config) o;
    src/main/java/at/favre/lib/crypto/bkdf/KeyDerivationFunction.java on lines 180..187

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 70.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method derive has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            public byte[] derive(byte[] salt, char[] password, int costFactor, byte[] infoParam, int outLengthByte) {
    Severity: Minor
    Found in src/main/java/at/favre/lib/crypto/bkdf/KeyDerivationFunction.java - About 35 mins to fix

      Method derive has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              public byte[] derive(byte[] salt, byte[] ikm, int costFactor, byte[] infoParam, int outLengthByte) {
      Severity: Minor
      Found in src/main/java/at/favre/lib/crypto/bkdf/KeyDerivationFunction.java - About 35 mins to fix

        Method derive has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            byte[] derive(byte[] salt, byte[] ikm, int costFactor, byte[] infoParam, int outLengthByte);
        Severity: Minor
        Found in src/main/java/at/favre/lib/crypto/bkdf/KeyDerivationFunction.java - About 35 mins to fix

          Method derive has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              byte[] derive(byte[] salt, char[] password, int costFactor, byte[] infoParam, int outLengthByte);
          Severity: Minor
          Found in src/main/java/at/favre/lib/crypto/bkdf/KeyDerivationFunction.java - About 35 mins to fix

            Method deriveSalt has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    private byte[] deriveSalt(int counter, byte[] salt, byte versionCode, byte costFactor, byte[] previousHash) {
            Severity: Minor
            Found in src/main/java/at/favre/lib/crypto/bkdf/PasswordHashUpgrader.java - About 35 mins to fix

              Method hashRaw has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                      HashData hashRaw(char[] password, byte[] salt16Byte, int costFactor) {
                          if (password.length > MAX_PASSWORD_LENGTH) {
                              throw new IllegalArgumentException("password length must not be greater than " + MAX_PASSWORD_LENGTH);
                          }
                          if (salt16Byte == null || salt16Byte.length < 16) {
              Severity: Minor
              Found in src/main/java/at/favre/lib/crypto/bkdf/PasswordHasher.java - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language