patrickfav/id-mask

View on GitHub

Showing 20 of 20 total issues

File IdMaskEngine.java has 391 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package at.favre.lib.idmask;

import at.favre.lib.bytes.Bytes;
import at.favre.lib.crypto.HKDF;

Severity: Minor
Found in modules/id-mask/src/main/java/at/favre/lib/idmask/IdMaskEngine.java - About 5 hrs to fix

    Method format has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

            private String format(String unformatted) {
                if (unformatted.length() < currentInterval * 2 - 1) {
                    return unformatted;
                } else {
                    if (unformatted.contains(currentSeparator)) {

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method unmask has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            @SuppressWarnings("Duplicates")
            @Override
            public byte[] unmask(CharSequence maskedId) {
                checkInput(maskedId);
    
    
    Severity: Minor
    Found in modules/id-mask/src/main/java/at/favre/lib/idmask/IdMaskEngine.java - About 1 hr to fix

      Method mask has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              @SuppressWarnings("Duplicates")
              @Override
              public CharSequence mask(byte[] plainId) {
                  Objects.requireNonNull(plainId, "id");
      
      
      Severity: Minor
      Found in modules/id-mask/src/main/java/at/favre/lib/idmask/IdMaskEngine.java - About 1 hr to fix

        Method main has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static void main(String args[]) {
                System.out.println("- Downloader started");
                File baseDirectory = new File(args[0]);
                System.out.println("- Using base directory: " + baseDirectory.getAbsolutePath());
        
        
        Severity: Minor
        Found in .mvn/wrapper/MavenWrapperDownloader.java - About 1 hr to fix

          Method mask has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  @Override
                  public CharSequence mask(byte[] plainId) {
                      if (plainId.length != getSupportedIdByteLength()) {
                          throw new IllegalArgumentException("input must be 8 byte long");
                      }
          Severity: Minor
          Found in modules/id-mask/src/main/java/at/favre/lib/idmask/IdMaskEngine.java - About 1 hr to fix

            Method unmask has 36 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    @Override
                    public byte[] unmask(CharSequence maskedId) {
                        checkInput(maskedId);
            
                        ByteBuffer bb = ByteBuffer.wrap(encoding.decode(maskedId));
            Severity: Minor
            Found in modules/id-mask/src/main/java/at/favre/lib/idmask/IdMaskEngine.java - About 1 hr to fix

              Method main has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static void main(String args[]) {
                      System.out.println("- Downloader started");
                      File baseDirectory = new File(args[0]);
                      System.out.println("- Using base directory: " + baseDirectory.getAbsolutePath());
              
              
              Severity: Minor
              Found in .mvn/wrapper/MavenWrapperDownloader.java - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method format has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      private String format(String unformatted) {
                          if (unformatted.length() < currentInterval * 2 - 1) {
                              return unformatted;
                          } else {
                              if (unformatted.contains(currentSeparator)) {

                Method decodeTo has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    private int decodeTo(byte[] target, CharSequence chars) {
                        Objects.requireNonNull(target);
                        chars = trimTrailingPadding(chars);
                        int bytesWritten = 0;
                        for (int charIdx = 0; charIdx < chars.length(); charIdx += alphabet.charsPerChunk) {
                Severity: Minor
                Found in modules/id-mask/src/main/java/at/favre/lib/idmask/BaseEncoding.java - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method createHmacInstance has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                        private synchronized Mac createHmacInstance() {
                            Mac mac = macThreadLocal.get();
                            if (mac == null) {
                                try {
                                    if (provider != null) {
                Severity: Minor
                Found in modules/id-mask/src/main/java/at/favre/lib/idmask/IdMaskEngine.java - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method getCipher has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                        synchronized Cipher getCipher() {
                            Cipher cipher = cipherWrapper.get();
                            if (cipher == null) {
                                try {
                                    if (provider != null) {
                Severity: Minor
                Found in modules/id-mask/src/main/java/at/favre/lib/idmask/IdMaskEngine.java - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                            } finally {
                                if (autoWipeMemory) {
                                    Bytes.wrapNullSafe(random).mutable().secureWipe();
                                    Bytes.wrapNullSafe(message).mutable().secureWipe();
                                    Bytes.wrapNullSafe(cipherText).mutable().secureWipe();
                modules/id-mask/src/main/java/at/favre/lib/idmask/IdMaskEngine.java on lines 366..372

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 44.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                            } finally {
                                if (autoWipeMemory) {
                                    Bytes.wrapNullSafe(entropyData).mutable().secureWipe();
                                    Bytes.wrapNullSafe(cipherText).mutable().secureWipe();
                                    Bytes.wrapNullSafe(message).mutable().secureWipe();
                modules/id-mask/src/main/java/at/favre/lib/idmask/IdMaskEngine.java on lines 317..323

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 44.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    @Benchmark
                    public void benchmarkMaskAndUnmask8Byte(BenchmarkState state, Blackhole blackhole) {
                        String encoded = state.idMaskEngine.mask(state.id);
                        blackhole.consume(state.idMaskEngine.unmask(encoded));
                        state.id++;
                modules/benchmark-jmh/src/main/java/at/favre/lib/idmaskbench/IdMaskAndHashIdsBenchmark.java on lines 100..105

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 43.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    @Benchmark
                    public void benchmarkHashIdEncodeDecode(BenchmarkState state, Blackhole blackhole) {
                        String encoded = state.hashids.encode(state.id);
                        blackhole.consume(state.hashids.decode(encoded));
                        state.id++;
                modules/benchmark-jmh/src/main/java/at/favre/lib/idmaskbench/IdMaskAndHashIdsBenchmark.java on lines 86..91

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 43.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                        ByteArray128bitMask(Config config) {
                            super(new IdMaskEngine.SixteenByteEngine(config.keyManager(), config.highSecurityMode(), config.encoding(),
                                    config.secureRandom(), config.securityProvider(), config.randomizedIds(), config.autoWipeMemory()), config);
                        }
                Severity: Major
                Found in modules/id-mask/src/main/java/at/favre/lib/idmask/IdMask.java and 3 other locations - About 30 mins to fix
                modules/id-mask/src/main/java/at/favre/lib/idmask/IdMask.java on lines 115..118
                modules/id-mask/src/main/java/at/favre/lib/idmask/IdMask.java on lines 140..143
                modules/id-mask/src/main/java/at/favre/lib/idmask/IdMask.java on lines 185..188

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 40.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                        BigIntegerIdMask(Config config) {
                            super(new IdMaskEngine.SixteenByteEngine(config.keyManager(), config.highSecurityMode(), config.encoding(),
                                    config.secureRandom(), config.securityProvider(), config.randomizedIds(), config.autoWipeMemory()), config);
                        }
                Severity: Major
                Found in modules/id-mask/src/main/java/at/favre/lib/idmask/IdMask.java and 3 other locations - About 30 mins to fix
                modules/id-mask/src/main/java/at/favre/lib/idmask/IdMask.java on lines 115..118
                modules/id-mask/src/main/java/at/favre/lib/idmask/IdMask.java on lines 140..143
                modules/id-mask/src/main/java/at/favre/lib/idmask/IdMask.java on lines 163..166

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 40.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                        LongIdTupleMask(Config config) {
                            super(new IdMaskEngine.SixteenByteEngine(config.keyManager(), config.highSecurityMode(), config.encoding(),
                                    config.secureRandom(), config.securityProvider(), config.randomizedIds(), config.autoWipeMemory()), config);
                        }
                Severity: Major
                Found in modules/id-mask/src/main/java/at/favre/lib/idmask/IdMask.java and 3 other locations - About 30 mins to fix
                modules/id-mask/src/main/java/at/favre/lib/idmask/IdMask.java on lines 140..143
                modules/id-mask/src/main/java/at/favre/lib/idmask/IdMask.java on lines 163..166
                modules/id-mask/src/main/java/at/favre/lib/idmask/IdMask.java on lines 185..188

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 40.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                        UuidMask(Config config) {
                            super(new IdMaskEngine.SixteenByteEngine(config.keyManager(), config.highSecurityMode(), config.encoding(),
                                    config.secureRandom(), config.securityProvider(), config.randomizedIds(), config.autoWipeMemory()), config);
                        }
                Severity: Major
                Found in modules/id-mask/src/main/java/at/favre/lib/idmask/IdMask.java and 3 other locations - About 30 mins to fix
                modules/id-mask/src/main/java/at/favre/lib/idmask/IdMask.java on lines 115..118
                modules/id-mask/src/main/java/at/favre/lib/idmask/IdMask.java on lines 163..166
                modules/id-mask/src/main/java/at/favre/lib/idmask/IdMask.java on lines 185..188

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 40.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Severity
                Category
                Status
                Source
                Language