patrickfav/singlestep-kdf

View on GitHub

Showing 5 of 7 total issues

Method main has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static void main(String args[]) {
        System.out.println("- Downloader started");
        File baseDirectory = new File(args[0]);
        System.out.println("- Using base directory: " + baseDirectory.getAbsolutePath());

Severity: Minor
Found in .mvn/wrapper/MavenWrapperDownloader.java - About 1 hr to fix

    Method main has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        public static void main(String args[]) {
            System.out.println("- Downloader started");
            File baseDirectory = new File(args[0]);
            System.out.println("- Using base directory: " + baseDirectory.getAbsolutePath());
    
    
    Severity: Minor
    Found in .mvn/wrapper/MavenWrapperDownloader.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getBlockLengthByte has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

            static int getBlockLengthByte(String algorithm) {
                String name = Objects.requireNonNull(algorithm).toLowerCase().trim().replace("-", "");
    
                if (name.startsWith("sha1") || name.startsWith("sha224") || name.startsWith("sha256")
                        || name.startsWith("hmacsha1") || name.startsWith("hmacsha256")) {
    Severity: Minor
    Found in src/main/java/at/favre/lib/crypto/singlstepkdf/HFunction.java - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                    return 128;
    Severity: Major
    Found in src/main/java/at/favre/lib/crypto/singlstepkdf/HFunction.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return 64;
      Severity: Major
      Found in src/main/java/at/favre/lib/crypto/singlstepkdf/HFunction.java - About 30 mins to fix
        Severity
        Category
        Status
        Source
        Language