patrickfav/uber-adb-tools

View on GitHub

Showing 87 of 87 total issues

Avoid too many return statements within this method.
Open

                return new LocationResult(Location.MAC_DEFAULT, MAC_DEFAULT);
Severity: Major
Found in src/main/java/at/favre/tools/uberadb/AdbLocationFinderImpl.java - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            if (!Arrays.equals(reportFilterIntent, arg.reportFilterIntent)) return false;
    Severity: Major
    Found in src/main/java/at/favre/tools/uberadb/ui/Arg.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return pkgHash != null ? pkgHash.equals(that.pkgHash) : that.pkgHash == null;
      Severity: Major
      Found in src/main/java/at/favre/tools/uberadb/parser/DumpsysPackageParser.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                if (keepData != arg.keepData) return false;
        Severity: Major
        Found in src/main/java/at/favre/tools/uberadb/ui/Arg.java - About 30 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                          if (adbLocation.location == AdbLocationFinder.Location.WIN_DEFAULT ||
                                  adbLocation.location == AdbLocationFinder.Location.MAC_DEFAULT ||
                                  adbLocation.location == AdbLocationFinder.Location.LINUX_DEFAULT) {
          Severity: Minor
          Found in src/main/java/at/favre/tools/uberadb/AdbTool.java and 1 other location - About 30 mins to fix
          src/main/java/at/favre/tools/uberadb/AdbTool.java on lines 202..202

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 40.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method parse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public List<AdbDevice> parse(String adbOutput) {
                  List<AdbDevice> devices = new ArrayList<>();
          
                  String[] lines = adbOutput.split("\\n");
          
          
          Severity: Minor
          Found in src/main/java/at/favre/tools/uberadb/parser/AdbDevicesParser.java - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method downscaleIfNeeded has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private static File downscaleIfNeeded(File localTempFile, Arg arg) {
                  if (localTempFile.exists() && localTempFile.isFile() && FileUtil.getFileExtension(localTempFile).equalsIgnoreCase("png") && localTempFile.length() > MAX_IMG_BYTE_SIZE) {
          
                      try {
                          while (localTempFile.length() > MAX_IMG_BYTE_SIZE) {
          Severity: Minor
          Found in src/main/java/at/favre/tools/uberadb/actions/BugReport.java - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language