Sign upLogin

patrickfav/under-the-hood

View on GitHub
Star
hood-core/src/main/java/at/favre/lib/hood/util/DeviceStatusUtil.java

Summary

Maintainability
C
1 day
Test Coverage

Method getNetworkConnectivityState has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

    public static ConnectionState getNetworkConnectivityState(@NonNull Context context) {
        if (ContextCompat.checkSelfPermission(context, Manifest.permission.ACCESS_NETWORK_STATE) == PackageManager.PERMISSION_GRANTED) {
            ConnectivityManager cm = (ConnectivityManager) context.getSystemService(Context.CONNECTIVITY_SERVICE);
            NetworkInfo activeNetwork = cm.getActiveNetworkInfo();
Severity: Minor
Found in hood-core/src/main/java/at/favre/lib/hood/util/DeviceStatusUtil.java - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getNetworkConnectivityState has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static ConnectionState getNetworkConnectivityState(@NonNull Context context) {
        if (ContextCompat.checkSelfPermission(context, Manifest.permission.ACCESS_NETWORK_STATE) == PackageManager.PERMISSION_GRANTED) {
            ConnectivityManager cm = (ConnectivityManager) context.getSystemService(Context.CONNECTIVITY_SERVICE);
            NetworkInfo activeNetwork = cm.getActiveNetworkInfo();
Severity: Minor
Found in hood-core/src/main/java/at/favre/lib/hood/util/DeviceStatusUtil.java - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

                            return ConnectionState.CONNECTED_BT;
    Severity: Major
    Found in hood-core/src/main/java/at/favre/lib/hood/util/DeviceStatusUtil.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                          return ConnectionState.CONNECTED_OTHER;
      Severity: Major
      Found in hood-core/src/main/java/at/favre/lib/hood/util/DeviceStatusUtil.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return ConnectionState.PERMISSION_NEEDED;
        Severity: Major
        Found in hood-core/src/main/java/at/favre/lib/hood/util/DeviceStatusUtil.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return ConnectionState.DISCONNECTED;
          Severity: Major
          Found in hood-core/src/main/java/at/favre/lib/hood/util/DeviceStatusUtil.java - About 30 mins to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                    if (wifi == null) {
            return Status.UNSUPPORTED;
        } else if (ContextCompat.checkSelfPermission(context, Manifest.permission.ACCESS_WIFI_STATE) != PackageManager.PERMISSION_GRANTED) {
            return Status.NEEDS_PERMISSION;
        } else if (wifi.isWifiEnabled()) {
            Severity: Major
            Found in hood-core/src/main/java/at/favre/lib/hood/util/DeviceStatusUtil.java and 2 other locations - About 55 mins to fix
            hood-core/src/main/java/at/favre/lib/hood/util/DeviceStatusUtil.java on lines 94..103
            hood-core/src/main/java/at/favre/lib/hood/util/DeviceStatusUtil.java on lines 136..144

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 66.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                    if (bluetoothAdapter == null) {
            return Status.UNSUPPORTED;
        } else if (ContextCompat.checkSelfPermission(context, Manifest.permission.BLUETOOTH) != PackageManager.PERMISSION_GRANTED) {
            return Status.NEEDS_PERMISSION;
        } else //noinspection MissingPermission
            Severity: Major
            Found in hood-core/src/main/java/at/favre/lib/hood/util/DeviceStatusUtil.java and 2 other locations - About 55 mins to fix
            hood-core/src/main/java/at/favre/lib/hood/util/DeviceStatusUtil.java on lines 115..123
            hood-core/src/main/java/at/favre/lib/hood/util/DeviceStatusUtil.java on lines 136..144

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 66.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                    if (adapter == null) {
            return Status.UNSUPPORTED;
        } else if (ContextCompat.checkSelfPermission(context, Manifest.permission.NFC) != PackageManager.PERMISSION_GRANTED) {
            return Status.NEEDS_PERMISSION;
        } else if (adapter.isEnabled()) {
            Severity: Major
            Found in hood-core/src/main/java/at/favre/lib/hood/util/DeviceStatusUtil.java and 2 other locations - About 55 mins to fix
            hood-core/src/main/java/at/favre/lib/hood/util/DeviceStatusUtil.java on lines 94..103
            hood-core/src/main/java/at/favre/lib/hood/util/DeviceStatusUtil.java on lines 115..123

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 66.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status