Sign upLogin

patrickfav/under-the-hood

View on GitHub
Star
hood-core/src/release/java/at/favre/lib/hood/internal/entries/ActionEntry.java

Summary

Maintainability
A
2 hrs
Test Coverage

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        @Override
        public View constructView(ViewGroup viewGroup, LayoutInflater inflater) {
            if (viewType == ViewTypes.VIEWTYPE_ACTION) {
                return inflater.inflate(R.layout.hoodlib_template_action_single, viewGroup, false);
            } else {
Severity: Minor
Found in hood-core/src/release/java/at/favre/lib/hood/internal/entries/ActionEntry.java and 1 other location - About 40 mins to fix
hood-core/src/release/java/at/favre/lib/hood/internal/entries/KeyValueEntry.java on lines 169..176

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

                view.findViewById(R.id.buttonLeft).setOnClickListener(new View.OnClickListener() {
                    @Override
                    public void onClick(View v) {
                        value.get(0).onClickAction.onClick(v, new AbstractMap.SimpleEntry<CharSequence, String>(value.get(0).label, null));
                    }
Severity: Minor
Found in hood-core/src/release/java/at/favre/lib/hood/internal/entries/ActionEntry.java and 2 other locations - About 35 mins to fix
hood-core/src/release/java/at/favre/lib/hood/internal/entries/ActionEntry.java on lines 119..124
hood-core/src/release/java/at/favre/lib/hood/internal/entries/ActionEntry.java on lines 103..108

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

                view.findViewById(R.id.button).setOnClickListener(new View.OnClickListener() {
                    @Override
                    public void onClick(View v) {
                        value.get(0).onClickAction.onClick(v, new AbstractMap.SimpleEntry<CharSequence, String>(value.get(0).label, null));
                    }
Severity: Minor
Found in hood-core/src/release/java/at/favre/lib/hood/internal/entries/ActionEntry.java and 2 other locations - About 35 mins to fix
hood-core/src/release/java/at/favre/lib/hood/internal/entries/ActionEntry.java on lines 111..116
hood-core/src/release/java/at/favre/lib/hood/internal/entries/ActionEntry.java on lines 119..124

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

                view.findViewById(R.id.buttonRight).setOnClickListener(new View.OnClickListener() {
                    @Override
                    public void onClick(View v) {
                        value.get(1).onClickAction.onClick(v, new AbstractMap.SimpleEntry<CharSequence, String>(value.get(1).label, null));
                    }
Severity: Minor
Found in hood-core/src/release/java/at/favre/lib/hood/internal/entries/ActionEntry.java and 2 other locations - About 35 mins to fix
hood-core/src/release/java/at/favre/lib/hood/internal/entries/ActionEntry.java on lines 111..116
hood-core/src/release/java/at/favre/lib/hood/internal/entries/ActionEntry.java on lines 103..108

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status