Sign upLogin

paulholden2/springcm-sdk

View on GitHub
Star

Showing 13 of 25 total issues

Method update_security has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def update_security(group:, access:)
      Helpers.validate_access!(access)
      if !group.is_a?(Springcm::Group)
        raise ArgumentError.new("Invalid group; must be a Springcm::Group")
      end
Severity: Minor
Found in lib/springcm-sdk/folder.rb - About 1 hr to fix

    Method template has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def template
      group = {}
      attributes_config.each { |attribute|
        type = attribute["Type"]
        if type == "DynamicDropDown"
    Severity: Minor
    Found in lib/springcm-sdk/attribute_group.rb - About 1 hr to fix

      Method folder has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          def folder(path: nil, uid: nil)
      if (path.nil? && uid.nil?) || (!path.nil? && !uid.nil?)
        raise ArgumentError.new("Specify exactly one of: path, uid")
      end
      if path == "/"
      Severity: Minor
      Found in lib/springcm-sdk/client.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method document has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def document(path: nil, uid: nil)
      if (path.nil? && uid.nil?) || (!path.nil? && !uid.nil?)
        raise ArgumentError.new("Specify exactly one of: path, uid")
      end
      conn = authorized_connection(url: object_api_url)
      Severity: Minor
      Found in lib/springcm-sdk/client.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method template has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def template
      group = {}
      attributes_config.each { |attribute|
        type = attribute["Type"]
        if type == "DynamicDropDown"
      Severity: Minor
      Found in lib/springcm-sdk/attribute_group.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method method_for_kind! has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def method_for_kind!(kind)
      method = nil
      if !@method_override.nil?
        method = @method_override
      elsif kind == Springcm::Folder
      Severity: Minor
      Found in lib/springcm-sdk/resource_list.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def initialize(data, field_name, subject, group, set, client)
      Severity: Minor
      Found in lib/springcm-sdk/applied_attribute_field.rb - About 45 mins to fix

        Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def initialize(data, subject, group, set, client)
        Severity: Minor
        Found in lib/springcm-sdk/applied_attribute_set_item.rb - About 35 mins to fix

          Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def initialize(data, set_name, subject, group, client)
          Severity: Minor
          Found in lib/springcm-sdk/applied_attribute_set.rb - About 35 mins to fix

            Method attribute_group has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                def attribute_group(name: nil, uid: nil)
      if (name.nil? && uid.nil?) || (!name.nil? && !uid.nil?)
        raise ArgumentError.new("Specify exactly one of: name, uid")
      end
      all_attribute_groups.select { |group|
            Severity: Minor
            Found in lib/springcm-sdk/account.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method method_missing has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def method_missing(m, *args, &block)
      mode = :get
      method = m.to_s
      if method.end_with?("=")
        mode = :set
            Severity: Minor
            Found in lib/springcm-sdk/object.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method connect has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def connect(safe=true)
      conn = Faraday.new(url: auth_url) do |conn|
        conn.request :retry, retry_statuses: [429], exceptions: [Springcm::RateLimitExceededError]
        conn.use Springcm::Middleware::RateLimit
        conn.use Springcm::Middleware::RetryConnectionFailed if @options[:retry_connection_failed]
            Severity: Minor
            Found in lib/springcm-sdk/client.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method authorized_connection has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def authorized_connection(*options)
      if !authenticated?
        connect!
      end
            Severity: Minor
            Found in lib/springcm-sdk/client.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language