payrollhero/singapore_cpf_calculator

View on GitHub

Showing 2 of 8 total issues

Class BaseCalculator has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

  class BaseCalculator

    class << self
      # @param [Fixnum] age
      # @return [true, false] returns true if the calculator applies to the employee's age.
Severity: Minor
Found in lib/singapore_cpf_calculator/base_calculator.rb - About 2 hrs to fix

    Method validate_params has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        def validate_params(
          date:,
          employee_contribution_type:,
          employer_contribution_type:,
          residency_status:,
    Severity: Minor
    Found in lib/singapore_cpf_calculator.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language