pboling/activerecord-tablefree

View on GitHub

Showing 3 of 3 total issues

Method from_query_string has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

      def from_query_string(query_string)
        if query_string.blank?
          new
        else
          params = query_string.split('&').collect do |chunk|
Severity: Minor
Found in lib/activerecord/tablefree.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method column has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def column(name, sql_type = nil, default = nil, null = true, cast_class_params = nil)
Severity: Minor
Found in lib/activerecord/tablefree.rb - About 35 mins to fix

    Method column has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def column(name, sql_type = nil, default = nil, null = true, cast_class_params = nil)
            cast_class = if sql_type.is_a?(Class) && sql_type < ActiveModel::Type::Value
                           sql_type
                         else
                           "ActiveRecord::Type::#{sql_type.to_s.camelize}".constantize rescue nil
    Severity: Minor
    Found in lib/activerecord/tablefree.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language