pbrisbin/tee-io

View on GitHub

Showing 14 issues of 14 total

Assignment Branch Condition size for run is too high. [20.74/20]
Open

    def run(&block)
      pid, stdin, out, err = POSIX::Spawn.popen4(*command)

      stdin.close
      stdout_thread = Thread.new { block.call(:stdout, out) }
Severity: Minor
Found in sdk/ruby/lib/tee_io/process.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method run has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def run(&block)
      pid, stdin, out, err = POSIX::Spawn.popen4(*command)

      stdin.close
      stdout_thread = Thread.new { block.call(:stdout, out) }
Severity: Minor
Found in sdk/ruby/lib/tee_io/process.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Parse error
Open

    <span .right>
Severity: Minor
Found in src/CommandContent.hs by hlint

Found

``` contentHeader :: CommandContent -> Widget contentHeader (Live _ command) = [whamlet|

<span .right>
      #{show $ commandCreatedAt command}

```

remove it.

Use newtype instead of data
Open

data OutputRequest = OutputRequest
    { reqContent :: Text
    }
Severity: Minor
Found in src/Handler/Output.hs by hlint

Found

data OutputRequest = OutputRequest{reqContent :: Text}

Why not

newtype OutputRequest = OutputRequest{reqContent :: Text}

Applying this change:

  • decreases laziness

Do not suppress exceptions.
Open

        rescue Errno::ESRCH
Severity: Minor
Found in sdk/ruby/lib/tee_io/process.rb by rubocop

Use newtype instead of data
Open

data CommandRequest = CommandRequest
    { reqDescription :: Maybe Text }
Severity: Minor
Found in src/Handler/Command.hs by hlint

Found

data CommandRequest = CommandRequest{reqDescription :: Maybe Text}

Why not

newtype CommandRequest = CommandRequest{reqDescription :: Maybe Text}

Applying this change:

  • decreases laziness

Avoid rescuing the Exception class. Perhaps you meant to rescue StandardError?
Open

    rescue Exception => ex
      if pid
        begin
          ::Process.kill("KILL", pid)
          ::Process.waitpid2(pid)
Severity: Minor
Found in sdk/ruby/lib/tee_io/process.rb by rubocop

Useless assignment to variable - ex.
Open

    rescue Exception => ex
Severity: Minor
Found in sdk/ruby/lib/tee_io/process.rb by rubocop

This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

Unnecessary hiding
Open

import Import hiding
    ( (<.)
    , (=.)
    , (==.)
    , (>.)
Severity: Minor
Found in src/Worker.hs by hlint

Found

import Import hiding ((<.), (=.), (==.), (>.), (||.), delete, isNothing, on, update)

Why not

import Import hiding ((<.), (==.), (>.), isNothing, on)

Reduce duplication
Open

    settings <- getAppSettings
Severity: Minor
Found in src/Application.hs by hlint

Found

``` settings <- getAppSettings foundation <- makeFoundation settings wsettings <- getDevSettings $ warpSettings foundation

```

Why not

Combine with src/Application.hs:152:5

FIXME found
Open

                 (TODO, FIXME, OPTIMIZE, HACK, REVIEW).
Severity: Minor
Found in .rubocop.yml by fixme

TODO found
Open

-- TODO: pick better names and release this as a small library
Severity: Minor
Found in src/Data/Time/Duration.hs by fixme

TODO found
Open

                 (TODO, FIXME, OPTIMIZE, HACK, REVIEW).
Severity: Minor
Found in .rubocop.yml by fixme

HACK found
Open

                 (TODO, FIXME, OPTIMIZE, HACK, REVIEW).
Severity: Minor
Found in .rubocop.yml by fixme
Severity
Category
Status