petergoldstein/dalli

View on GitHub

Showing 40 of 40 total issues

Method fetch has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def fetch(key, ttl=nil, options=nil)
      options = options.nil? ? CACHE_NILS : options.merge(CACHE_NILS) if @options[:cache_nils]
      val = get(key, options)
      not_found = @options[:cache_nils] ?
        val == Dalli::Server::NOT_FOUND :
Severity: Minor
Found in lib/dalli/client.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method replace has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def replace(key, value, ttl, cas, options)
Severity: Minor
Found in lib/dalli/server.rb - About 35 mins to fix

    Method replace_cas has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def replace_cas(key, value, cas, ttl=nil, options=nil)
    Severity: Minor
    Found in lib/dalli/cas/client.rb - About 35 mins to fix

      Method set has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def set(key, value, ttl, cas, options)
      Severity: Minor
      Found in lib/dalli/server.rb - About 35 mins to fix

        Method set_cas has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def set_cas(key, value, cas, ttl=nil, options=nil)
        Severity: Minor
        Found in lib/dalli/cas/client.rb - About 35 mins to fix

          Method decr_incr has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def decr_incr(opcode, key, count, ttl, default)
          Severity: Minor
          Found in lib/dalli/server.rb - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                OP_FORMAT = {
                  :get => 'a*',
                  :set => 'NNa*a*',
                  :add => 'NNa*a*',
                  :replace => 'NNa*a*',
            Severity: Minor
            Found in lib/dalli/server.rb and 1 other location - About 35 mins to fix
            lib/dalli/server.rb on lines 615..632

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 36.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                RESPONSE_CODES = {
                  0 => 'No error',
                  1 => 'Key not found',
                  2 => 'Key exists',
                  3 => 'Value too large',
            Severity: Minor
            Found in lib/dalli/server.rb and 1 other location - About 35 mins to fix
            lib/dalli/server.rb on lines 663..680

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 36.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method get_session has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                  def get_session(env, sid)
                    sid = generate_sid unless sid and !sid.empty?
                    begin
                      session = @pool.get(sid) || {}
                    rescue Dalli::DalliError => ex
            Severity: Minor
            Found in lib/action_dispatch/middleware/session/dalli_store.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method parse_hostname has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                def parse_hostname(str)
                  res = str.match(/\A(\[([\h:]+)\]|[^:]+)(?::(\d+))?(?::(\d+))?\z/)
                  raise Dalli::DalliError, "Could not parse hostname #{str}" if res.nil? || res[1] == '[]'
                  hostnam = res[2] || res[1]
                  if hostnam =~ /\A\//
            Severity: Minor
            Found in lib/dalli/server.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method binary_search has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                  def binary_search(ary, value)
                    upper = ary.size - 1
                    lower = 0
            
                    while (lower <= upper) do
            Severity: Minor
            Found in lib/dalli/ring.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method perform_multi_response_start has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def perform_multi_response_start(servers)
                  servers.each do |server|
                    next unless server.alive?
                    begin
                      server.multi_response_start
            Severity: Minor
            Found in lib/dalli/client.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method add has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def add(key, value, ttl, options)
                  (value, flags) = serialize(key, value, options)
                  ttl = sanitize_ttl(ttl)
            
                  guard_max_value(key, value) do
            Severity: Minor
            Found in lib/dalli/server.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method read_available has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                  def read_available
                    value = String.new('')
                    while true
                      begin
                        value << read_nonblock(8196)
            Severity: Minor
            Found in lib/dalli/socket.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method set has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def set(key, value, ttl, cas, options)
                  (value, flags) = serialize(key, value, options)
                  ttl = sanitize_ttl(ttl)
            
                  guard_max_value(key, value) do
            Severity: Minor
            Found in lib/dalli/server.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method cas_response has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def cas_response
                  (_, _, status, count, _, cas) = read_header.unpack(CAS_HEADER)
                  read(count) if count > 0  # this is potential data that we don't care about
                  if status == 1
                    nil
            Severity: Minor
            Found in lib/dalli/server.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method alive? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def alive?
                  return true if @sock
            
                  if @last_down_at && @last_down_at + options[:down_retry_delay] >= Time.now
                    time = @last_down_at + options[:down_retry_delay] - Time.now
            Severity: Minor
            Found in lib/dalli/server.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method replace has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def replace(key, value, ttl, cas, options)
                  (value, flags) = serialize(key, value, options)
                  ttl = sanitize_ttl(ttl)
            
                  guard_max_value(key, value) do
            Severity: Minor
            Found in lib/dalli/server.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                def decr(key, amt=1, ttl=nil, default=nil)
                  raise ArgumentError, "Positive values only: #{amt}" if amt < 0
                  perform(:decr, key, amt.to_i, ttl_or_default(ttl), default)
            Severity: Minor
            Found in lib/dalli/client.rb and 1 other location - About 15 mins to fix
            lib/dalli/client.rb on lines 185..187

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 25.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                def incr(key, amt=1, ttl=nil, default=nil)
                  raise ArgumentError, "Positive values only: #{amt}" if amt < 0
                  perform(:incr, key, amt.to_i, ttl_or_default(ttl), default)
            Severity: Minor
            Found in lib/dalli/client.rb and 1 other location - About 15 mins to fix
            lib/dalli/client.rb on lines 204..206

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 25.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language