petr-muller/pyff

View on GitHub

Showing 6 of 6 total issues

File functions.py has 350 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""This module contains code that handles comparing function implementations"""

import ast
import logging
from itertools import zip_longest
Severity: Minor
Found in pyff/functions.py - About 4 hrs to fix

    File imports.py has 328 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    """This module contains code that handles comparing imports"""
    
    import collections.abc
    import types
    from typing import Set, Dict, Union, Optional, FrozenSet, Mapping, cast
    Severity: Minor
    Found in pyff/imports.py - About 3 hrs to fix

      Function find_external_name_matches has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

      def find_external_name_matches(
          old: ast.AST, new: ast.AST, old_imports: pi.ImportedNames, new_imports: pi.ImportedNames
      ) -> Optional[ExternalNameUsageChange]:
          """Tests two statements for semantical equality w.r.t. external name usage.
      
      
      Severity: Minor
      Found in pyff/statements.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function find_those_pythonz has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      def find_those_pythonz(
          directory: pathlib.Path
      ) -> Tuple[FrozenSet[pathlib.Path], FrozenSet[pathlib.Path]]:
          """Find Python packages and modules in a given directory"""
          traverse_directories: Set[pathlib.Path] = {directory}
      Severity: Minor
      Found in pyff/directories.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function canonical_ast has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def canonical_ast(self) -> Union[ast.Name, ast.Attribute]:
              """Returns AST node for the full name
      
              Example: For 'join' imported by 'from os.path import join', returns AST of 'os.path.join'"""
              node: Union[ast.Name, ast.Attribute]
      Severity: Minor
      Found in pyff/imports.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function compare_import_usage has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def compare_import_usage(  # pylint: disable=invalid-name
      Severity: Minor
      Found in pyff/functions.py - About 35 mins to fix
        Severity
        Category
        Status
        Source
        Language