Sign upLogin

phergie/phergie-irc-bot-react

View on GitHub
Star

Showing 10 of 10 total issues

EventQueue has 71 functions (exceeds 20 allowed). Consider refactoring.
Open

class EventQueue implements EventQueueInterface
{
    /**
     * Internal priority queue.
     *
Severity: Major
Found in src/EventQueue.php - About 1 day to fix

    File EventQueue.php has 355 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * Phergie (http://phergie.org)
 * @copyright Copyright (c) 2008-2014 Phergie Development Team (http://phergie.org)
 * @license http://phergie.org/license Simplified BSD License
    Severity: Minor
    Found in src/EventQueue.php - About 4 hrs to fix

      File Bot.php has 321 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
/**
 * Phergie (http://phergie.org)
 *
 * @link http://github.com/phergie/phergie-irc-bot-react for the canonical source repository
      Severity: Minor
      Found in src/Bot.php - About 3 hrs to fix

        Bot has 25 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class Bot
{
    /**
     * IRC client in use by the bot
     *
        Severity: Minor
        Found in src/Bot.php - About 2 hrs to fix

          Method getPriorities has 44 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function getPriorities()
    {
        return array_flip([
            'RESTART',
            'SQUIT',
          Severity: Minor
          Found in src/EventQueue.php - About 1 hr to fix

            Function processPlugins has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function processPlugins(array $plugins, array $processors, \SplObjectStorage $processedPlugins = null)
    {
        // Initialise store of already-processed plugins, to prevent container-based endless recursion
        if ($processedPlugins === null) {
            $processedPlugins = new \SplObjectStorage;
            Severity: Minor
            Found in src/Bot.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method ircUserhost has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function ircUserhost($nickname1, $nickname2 = null, $nickname3 = null, $nickname4 = null, $nickname5 = null)
            Severity: Minor
            Found in src/EventQueue.php - About 35 mins to fix

              Function processOutgoingEvents has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function processOutgoingEvents(ConnectionInterface $connection, WriteStream $write)
    {
        $client = $this->getClient();
        $queue = $this->getEventQueueFactory()->getEventQueue($connection);
              Severity: Minor
              Found in src/Bot.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function validatePluginEvents has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function validatePluginEvents(PluginInterface $plugin)
    {
        $events = $plugin->getSubscribedEvents();
        if (!is_array($events)) {
            throw new \RuntimeException(
              Severity: Minor
              Found in src/Bot.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function registerPluginSubscribers has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function registerPluginSubscribers(array $plugins)
    {
        $client = $this->getClient();
        foreach ($plugins as $plugin) {
            $this->validatePluginEvents($plugin);
              Severity: Minor
              Found in src/Bot.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language