phlegx/macker

View on GitHub

Showing 3 of 3 total issues

Method vendor_list has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def vendor_list(straight = false)
    raw_vendor_list = if straight
                        raw_vendor_list_straight
                      else
                        raw_vendor_list_careful
Severity: Minor
Found in lib/macker.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def initialize(mac, opts = {})
      case mac
      when Address
        @val      = mac.to_i
        @name     = mac.name
Severity: Minor
Found in lib/macker/address.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method raw_vendor_list_careful has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def raw_vendor_list_careful(rescue_straight = true)
    res = read_from_cache
    raise if res.to_s.empty?
    res
  rescue
Severity: Minor
Found in lib/macker.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language