php-yaoi/php-yaoi

View on GitHub
src/Cli/Command/RequestMapper.php

Summary

Maintainability
C
1 day
Test Coverage

Function read has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public function read(Request $request, array $options)
    {
        $this->def = new PrepareDefinition($options);

        $tokens = $request->server()->argv;
Severity: Minor
Found in src/Cli/Command/RequestMapper.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function processToken has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    private function processToken()
    {
        $optionFound = null;
        if (($optionName = $this->token->afterStarts(Runner::OPTION_NAME)) && isset($this->def->byName[$optionName])) {
            $optionFound = $this->def->byName[$optionName];
Severity: Minor
Found in src/Cli/Command/RequestMapper.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method processToken has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function processToken()
    {
        $optionFound = null;
        if (($optionName = $this->token->afterStarts(Runner::OPTION_NAME)) && isset($this->def->byName[$optionName])) {
            $optionFound = $this->def->byName[$optionName];
Severity: Minor
Found in src/Cli/Command/RequestMapper.php - About 1 hr to fix

    Method read has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function read(Request $request, array $options)
        {
            $this->def = new PrepareDefinition($options);
    
            $tokens = $request->server()->argv;
    Severity: Minor
    Found in src/Cli/Command/RequestMapper.php - About 1 hr to fix

      Function processOption has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          private function processOption()
          {
              if ($this->option->isRequired) {
                  unset($this->def->requiredOptions[$this->option->name]);
              }
      Severity: Minor
      Found in src/Cli/Command/RequestMapper.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                  return;
      Severity: Major
      Found in src/Cli/Command/RequestMapper.php - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status