Sign upLogin

phpffcms/ffcms-core

View on GitHub
Star
src/Helper/ModelFilters.php

Summary

Maintainability
B
4 hrs
Test Coverage

ModelFilters has 25 functions (exceeds 20 allowed). Consider refactoring.
Open

class ModelFilters
{

    /**
     * Filter ['object', 'length_min', 'length']
Severity: Minor
Found in src/Helper/ModelFilters.php - About 2 hrs to fix

    Function isFile has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function isFile($object, $value): bool
    {
        // allow empty fields, "required" option filter that
        if ($object === null) {
            return true;
    Severity: Minor
    Found in src/Helper/ModelFilters.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return true;
    Severity: Major
    Found in src/Helper/ModelFilters.php - About 30 mins to fix

      Function sizeFile has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function sizeFile($object, $value): bool
    {
        // allow empty field, validate on filter 'required'
        if ($object === null) {
            return true;
      Severity: Minor
      Found in src/Helper/ModelFilters.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status