src/Phug/DevTool/Command/InstallCommand.php
Avoid assigning values to variables in if clauses and the like (line '22', column '13'). Open
Open
protected function execute(InputInterface $input, OutputInterface $output)
{
$app = $this->getApplication();
if ($code = $app->runShellCommand('composer', ['self-update'])) {
- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}
Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
Call to undeclared method \Phug\DevTool\Command\InstallCommand::setName
Open
Open
$this->setName('install')
- Exclude checks
Parameter $input
has undeclared type \Symfony\Component\Console\Input\InputInterface
Open
Open
protected function execute(InputInterface $input, OutputInterface $output)
- Exclude checks
Parameter $output
has undeclared type \Symfony\Component\Console\Output\OutputInterface
Open
Open
protected function execute(InputInterface $input, OutputInterface $output)
- Exclude checks