phug-php/dev-tool

View on GitHub
src/Phug/DevTool/Command/UnitTestsRunCommand.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid assigning values to variables in if clauses and the like (line '34', column '13').
Open

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $args = [
            '--verbose',
            '--configuration' => $this->getApplication()->getConfigFilePath('phpunit.xml'),

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid assigning values to variables in if clauses and the like (line '42', column '13').
Open

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $args = [
            '--verbose',
            '--configuration' => $this->getApplication()->getConfigFilePath('phpunit.xml'),

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid assigning values to variables in if clauses and the like (line '38', column '13').
Open

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $args = [
            '--verbose',
            '--configuration' => $this->getApplication()->getConfigFilePath('phpunit.xml'),

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Reference to constant VALUE_OPTIONAL from undeclared class \Symfony\Component\Console\Input\InputOption
Open

            ->addOption('group', null, InputOption::VALUE_OPTIONAL, 'Excute only a tests group?', false)

Reference to constant VALUE_OPTIONAL from undeclared class \Symfony\Component\Console\Input\InputOption
Open

            ->addOption('coverage-clover', null, InputOption::VALUE_OPTIONAL, 'Save coverage info as XML?', false)

Parameter $output has undeclared type \Symfony\Component\Console\Output\OutputInterface
Open

    protected function execute(InputInterface $input, OutputInterface $output)

Call to method getOption from undeclared class \Symfony\Component\Console\Input\InputInterface
Open

        if ($path = $input->getOption('coverage-html')) {

Call to method getOption from undeclared class \Symfony\Component\Console\Input\InputInterface
Open

        if ($input->getOption('coverage-text')) {

Reference to constant VALUE_OPTIONAL from undeclared class \Symfony\Component\Console\Input\InputOption
Open

            ->addOption('coverage-html', null, InputOption::VALUE_OPTIONAL, 'Save coverage info as HTML?', false)

Call to method getOption from undeclared class \Symfony\Component\Console\Input\InputInterface
Open

        if ($group = $input->getOption('group')) {

Parameter $input has undeclared type \Symfony\Component\Console\Input\InputInterface
Open

    protected function execute(InputInterface $input, OutputInterface $output)

Call to method getOption from undeclared class \Symfony\Component\Console\Input\InputInterface
Open

        if ($path = $input->getOption('coverage-clover')) {

Call to undeclared method \Phug\DevTool\Command\UnitTestsRunCommand::setName
Open

        $this->setName('unit-tests:run')

Reference to constant VALUE_NONE from undeclared class \Symfony\Component\Console\Input\InputOption
Open

            ->addOption('coverage-text', null, InputOption::VALUE_NONE, 'Display coverage info?')

There are no issues that match your filters.

Category
Status