Sign upLogin

piotrmurach/github

View on GitHub
Star
lib/github_api/api.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Class API has 28 methods (exceeds 20 allowed). Consider refactoring.
Open

  class API
    include Constants
    include Authorization
    include MimeType
    include RateLimit
Severity: Minor
Found in lib/github_api/api.rb - About 3 hrs to fix

    Method method_added has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.method_added(method_name)
      method_name = method_name.to_s.gsub(/_with(out)?_callback_.*$/, '')
      # Only subclasses matter
      return if self.root?
      return if extra_methods.include?(method_name)
    Severity: Minor
    Found in lib/github_api/api.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

          return if public_method_defined?(with_method)
    Severity: Major
    Found in lib/github_api/api.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

            return if public_method_defined?(with_method)
      Severity: Major
      Found in lib/github_api/api.rb - About 30 mins to fix

        Method namespace has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def self.namespace(*names)
      options = names.last.is_a?(Hash) ? names.pop : {}
      names   = names.map(&:to_sym)
      name    = names.pop
        Severity: Minor
        Found in lib/github_api/api.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status