pixelfed/pixelfed

View on GitHub
app/Http/Controllers/Admin/AdminUserController.php

Summary

Maintainability
C
1 day
Test Coverage

File AdminUserController.php has 267 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace App\Http\Controllers\Admin;

use Cache, DB;
Severity: Minor
Found in app/Http/Controllers/Admin/AdminUserController.php - About 2 hrs to fix

    Method userEditSubmit has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function userEditSubmit(Request $request, $id)
        {
            $user = User::findOrFail($id);
            $profile = $user->profile;
            $changed = false;
    Severity: Minor
    Found in app/Http/Controllers/Admin/AdminUserController.php - About 1 hr to fix

      Method userModerate has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function userModerate(Request $request)
          {
              $this->validate($request, [
                  'profile_id' => 'required|exists:profiles,id',
                  'action' => 'required|in:cw,no_autolink,unlisted'
      Severity: Minor
      Found in app/Http/Controllers/Admin/AdminUserController.php - About 1 hr to fix

        Method userDeleteProcess has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function userDeleteProcess(Request $request, $id)
            {
                $user = User::findOrFail($id);
                $profile = $user->profile;
        
        
        Severity: Minor
        Found in app/Http/Controllers/Admin/AdminUserController.php - About 1 hr to fix

          Function userEditSubmit has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public function userEditSubmit(Request $request, $id)
              {
                  $user = User::findOrFail($id);
                  $profile = $user->profile;
                  $changed = false;
          Severity: Minor
          Found in app/Http/Controllers/Admin/AdminUserController.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status