Sign upLogin

pixelfed/pixelfed

View on GitHub
Star
app/Http/Controllers/ComposeController.php

Summary

Maintainability
F
6 days
Test Coverage

File ComposeController.php has 688 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace App\Http\Controllers;

use App\Collection;
Severity: Major
Found in app/Http/Controllers/ComposeController.php - About 1 day to fix

    Method store has 148 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function store(Request $request)
    {
        $this->validate($request, [
            'caption' => 'nullable|string|max:'.config_cache('pixelfed.max_caption_length', 500),
            'media.*' => 'required',
    Severity: Major
    Found in app/Http/Controllers/ComposeController.php - About 5 hrs to fix

      Function store has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
      Open

          public function store(Request $request)
    {
        $this->validate($request, [
            'caption' => 'nullable|string|max:'.config_cache('pixelfed.max_caption_length', 500),
            'media.*' => 'required',
      Severity: Minor
      Found in app/Http/Controllers/ComposeController.php - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method mediaUpload has 78 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function mediaUpload(Request $request)
    {
        abort_if(! $request->user(), 403);

        $this->validate($request, [
      Severity: Major
      Found in app/Http/Controllers/ComposeController.php - About 3 hrs to fix

        Method searchLocation has 71 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function searchLocation(Request $request)
    {
        abort_if(! $request->user(), 403);
        $this->validate($request, [
            'q' => 'required|string|max:100',
        Severity: Major
        Found in app/Http/Controllers/ComposeController.php - About 2 hrs to fix

          Method storeText has 71 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function storeText(Request $request)
    {
        abort_unless(config('exp.top'), 404);
        $this->validate($request, [
            'caption' => 'nullable|string|max:'.config_cache('pixelfed.max_caption_length', 500),
          Severity: Major
          Found in app/Http/Controllers/ComposeController.php - About 2 hrs to fix

            Function storeText has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
            Open

                public function storeText(Request $request)
    {
        abort_unless(config('exp.top'), 404);
        $this->validate($request, [
            'caption' => 'nullable|string|max:'.config_cache('pixelfed.max_caption_length', 500),
            Severity: Minor
            Found in app/Http/Controllers/ComposeController.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method createPoll has 39 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function createPoll(Request $request)
    {
        $this->validate($request, [
            'caption' => 'nullable|string|max:'.config_cache('pixelfed.max_caption_length', 500),
            'cw' => 'nullable|boolean',
            Severity: Minor
            Found in app/Http/Controllers/ComposeController.php - About 1 hr to fix

              Method mediaUpdate has 37 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function mediaUpdate(Request $request)
    {
        $this->validate($request, [
            'id' => 'required',
            'file' => function () {
              Severity: Minor
              Found in app/Http/Controllers/ComposeController.php - About 1 hr to fix

                Method searchTag has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function searchTag(Request $request)
    {
        abort_if(! $request->user(), 403);

        $this->validate($request, [
                Severity: Minor
                Found in app/Http/Controllers/ComposeController.php - About 1 hr to fix

                  Method searchMentionAutocomplete has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function searchMentionAutocomplete(Request $request)
    {
        abort_if(! $request->user(), 403);

        $this->validate($request, [
                  Severity: Minor
                  Found in app/Http/Controllers/ComposeController.php - About 1 hr to fix

                    Function mediaUpload has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function mediaUpload(Request $request)
    {
        abort_if(! $request->user(), 403);

        $this->validate($request, [
                    Severity: Minor
                    Found in app/Http/Controllers/ComposeController.php - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Avoid too many return statements within this method.
                    Open

                            return $places;
                    Severity: Major
                    Found in app/Http/Controllers/ComposeController.php - About 30 mins to fix

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                              foreach ($tagged as $tg) {
            $mt = new MediaTag;
            $mt->status_id = $status->id;
            $mt->media_id = $status->media->first()->id;
            $mt->profile_id = $tg['id'];
                      Severity: Major
                      Found in app/Http/Controllers/ComposeController.php and 1 other location - About 2 hrs to fix
                      app/Http/Controllers/ComposeController.php on lines 698..711

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 137.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                              foreach ($tagged as $tg) {
            $mt = new MediaTag;
            $mt->status_id = $status->id;
            $mt->media_id = $status->media->first()->id;
            $mt->profile_id = $tg['id'];
                      Severity: Major
                      Found in app/Http/Controllers/ComposeController.php and 1 other location - About 2 hrs to fix
                      app/Http/Controllers/ComposeController.php on lines 584..597

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 137.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 5 locations. Consider refactoring.
                      Open

                              if (config_cache('pixelfed.enforce_account_limit') == true) {
            $size = Cache::remember($user->storageUsedKey(), now()->addDays(3), function () use ($user) {
                return Media::whereUserId($user->id)->sum('size') / 1000;
            });
            $limit = (int) config_cache('pixelfed.max_account_size');
                      Severity: Major
                      Found in app/Http/Controllers/ComposeController.php and 4 other locations - About 1 hr to fix
                      app/Http/Controllers/Api/ApiV1Controller.php on lines 1757..1765
                      app/Http/Controllers/Api/ApiV1Controller.php on lines 1974..1982
                      app/Http/Controllers/Api/ApiV2Controller.php on lines 249..257
                      app/Http/Controllers/DirectMessageController.php on lines 603..611

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 119.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                              if (config('costar.enabled') == true) {
            $blockedKeywords = config('costar.keyword.block');
            if ($blockedKeywords !== null && $request->caption) {
                $keywords = config('costar.keyword.block');
                foreach ($keywords as $kw) {
                      Severity: Major
                      Found in app/Http/Controllers/ComposeController.php and 2 other locations - About 1 hr to fix
                      app/Http/Controllers/Api/ApiV1Controller.php on lines 3330..3340
                      app/Http/Controllers/ComposeController.php on lines 650..660

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 108.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                              if (config('costar.enabled') == true) {
            $blockedKeywords = config('costar.keyword.block');
            if ($blockedKeywords !== null && $request->caption) {
                $keywords = config('costar.keyword.block');
                foreach ($keywords as $kw) {
                      Severity: Major
                      Found in app/Http/Controllers/ComposeController.php and 2 other locations - About 1 hr to fix
                      app/Http/Controllers/Api/ApiV1Controller.php on lines 3330..3340
                      app/Http/Controllers/ComposeController.php on lines 480..490

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 108.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status