pixelfed/pixelfed

View on GitHub

Showing 323 of 326 total issues

File DirectMessageController.php has 709 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace App\Http\Controllers;

use Auth, Cache;
Severity: Major
Found in app/Http/Controllers/DirectMessageController.php - About 1 day to fix

    Identical blocks of code found in 6 locations. Consider refactoring.
    Open

                    $dms = DirectMessage::select('id', 'type', 'to_id', 'from_id', 'id', 'status_id', 'is_hidden', 'meta', 'created_at', 'read_at')
                    ->whereToId($profile)
                    ->with(['author','status'])
                    ->whereIsHidden(true)
                    ->orderBy('id', 'desc')
    Severity: Major
    Found in app/Http/Controllers/DirectMessageController.php and 5 other locations - About 1 day to fix
    app/Http/Controllers/DirectMessageController.php on lines 44..81
    app/Http/Controllers/DirectMessageController.php on lines 85..121
    app/Http/Controllers/DirectMessageController.php on lines 166..203
    app/Http/Controllers/DirectMessageController.php on lines 207..243
    app/Http/Controllers/DirectMessageController.php on lines 247..284

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 250.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 6 locations. Consider refactoring.
    Open

                    $dms = DirectMessage::selectRaw('*, max(created_at) as createdAt')
                    ->whereToId($profile)
                    ->with(['author','status'])
                    ->whereIsHidden(false)
                    ->groupBy('from_id')
    Severity: Major
    Found in app/Http/Controllers/DirectMessageController.php and 5 other locations - About 1 day to fix
    app/Http/Controllers/DirectMessageController.php on lines 44..81
    app/Http/Controllers/DirectMessageController.php on lines 85..121
    app/Http/Controllers/DirectMessageController.php on lines 125..162
    app/Http/Controllers/DirectMessageController.php on lines 207..243
    app/Http/Controllers/DirectMessageController.php on lines 247..284

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 250.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 6 locations. Consider refactoring.
    Open

                    $dms = DirectMessage::selectRaw('*, max(created_at) as createdAt')
                    ->whereToId($profile)
                    ->with(['author','status'])
                    ->whereIsHidden(true)
                    ->groupBy('from_id')
    Severity: Major
    Found in app/Http/Controllers/DirectMessageController.php and 5 other locations - About 1 day to fix
    app/Http/Controllers/DirectMessageController.php on lines 44..81
    app/Http/Controllers/DirectMessageController.php on lines 85..121
    app/Http/Controllers/DirectMessageController.php on lines 125..162
    app/Http/Controllers/DirectMessageController.php on lines 166..203
    app/Http/Controllers/DirectMessageController.php on lines 207..243

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 250.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 6 locations. Consider refactoring.
    Open

                    $dms = DirectMessage::select('id', 'type', 'to_id', 'from_id', 'id', 'status_id', 'is_hidden', 'meta', 'created_at', 'read_at')
                    ->whereFromId($profile)
                    ->with(['author','status'])
                    ->orderBy('id', 'desc')
                    ->when($page, function($q, $page) {
    Severity: Major
    Found in app/Http/Controllers/DirectMessageController.php and 5 other locations - About 1 day to fix
    app/Http/Controllers/DirectMessageController.php on lines 44..81
    app/Http/Controllers/DirectMessageController.php on lines 125..162
    app/Http/Controllers/DirectMessageController.php on lines 166..203
    app/Http/Controllers/DirectMessageController.php on lines 207..243
    app/Http/Controllers/DirectMessageController.php on lines 247..284

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 250.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 6 locations. Consider refactoring.
    Open

                    $dms = DirectMessage::selectRaw('*, max(created_at) as createdAt')
                    ->whereFromId($profile)
                    ->with(['author','status'])
                    ->groupBy('to_id')
                    ->orderBy('createdAt', 'desc')
    Severity: Major
    Found in app/Http/Controllers/DirectMessageController.php and 5 other locations - About 1 day to fix
    app/Http/Controllers/DirectMessageController.php on lines 44..81
    app/Http/Controllers/DirectMessageController.php on lines 85..121
    app/Http/Controllers/DirectMessageController.php on lines 125..162
    app/Http/Controllers/DirectMessageController.php on lines 166..203
    app/Http/Controllers/DirectMessageController.php on lines 247..284

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 250.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 6 locations. Consider refactoring.
    Open

                    $dms = DirectMessage::select('id', 'type', 'to_id', 'from_id', 'id', 'status_id', 'is_hidden', 'meta', 'created_at', 'read_at')
                    ->whereToId($profile)
                    ->with(['author','status'])
                    ->whereIsHidden(false)
                    ->when($page, function($q, $page) {
    Severity: Major
    Found in app/Http/Controllers/DirectMessageController.php and 5 other locations - About 1 day to fix
    app/Http/Controllers/DirectMessageController.php on lines 85..121
    app/Http/Controllers/DirectMessageController.php on lines 125..162
    app/Http/Controllers/DirectMessageController.php on lines 166..203
    app/Http/Controllers/DirectMessageController.php on lines 207..243
    app/Http/Controllers/DirectMessageController.php on lines 247..284

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 250.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method browse has 249 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function browse(Request $request)
        {
            $this->validate($request, [
                'a' => 'nullable|string|in:inbox,sent,filtered',
                'page' => 'nullable|integer|min:1|max:99'
    Severity: Major
    Found in app/Http/Controllers/DirectMessageController.php - About 1 day to fix

      Function statusFirstOrFetch has a Cognitive Complexity of 60 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function statusFirstOrFetch($url, $replyTo = false)
          {
              $url = self::validateUrl($url);
              if($url == false) {
                  return;
      Severity: Minor
      Found in app/Util/ActivityPub/Helpers.php - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File Inbox.php has 535 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
      
      namespace App\Util\ActivityPub;
      
      use Cache, DB, Log, Purify, Redis, Validator;
      Severity: Major
      Found in app/Util/ActivityPub/Inbox.php - About 1 day to fix

        File PublicApiController.php has 504 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
        
        namespace App\Http\Controllers;
        
        use Illuminate\Http\Request;
        Severity: Major
        Found in app/Http/Controllers/PublicApiController.php - About 1 day to fix

          File web.php has 420 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
          
          Route::domain(config('pixelfed.domain.admin'))->prefix('i/admin')->group(function () {
              Route::redirect('/', '/dashboard');
              Route::redirect('timeline', config('app.url').'/timeline');
          Severity: Minor
          Found in routes/web.php - About 6 hrs to fix

            File AccountController.php has 419 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
            
            namespace App\Http\Controllers;
            
            use Auth; 
            Severity: Minor
            Found in app/Http/Controllers/AccountController.php - About 6 hrs to fix

              File Helpers.php has 416 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              <?php
              
              namespace App\Util\ActivityPub;
              
              use DB, Cache, Purify, Storage, Request, Validator;
              Severity: Minor
              Found in app/Util/ActivityPub/Helpers.php - About 6 hrs to fix

                Profile has 38 functions (exceeds 20 allowed). Consider refactoring.
                Open

                class Profile extends Model
                {
                    use HasSnowflakePrimary, SoftDeletes;
                
                    /**
                Severity: Minor
                Found in app/Profile.php - About 5 hrs to fix

                  Function handleDirectMessage has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function handleDirectMessage()
                      {
                          $activity = $this->payload['object'];
                          $actor = $this->actorFirstOrCreate($this->payload['actor']);
                          $profile = Profile::whereNull('domain')
                  Severity: Minor
                  Found in app/Util/ActivityPub/Inbox.php - About 4 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method statusFirstOrFetch has 110 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public static function statusFirstOrFetch($url, $replyTo = false)
                      {
                          $url = self::validateUrl($url);
                          if($url == false) {
                              return;
                  Severity: Major
                  Found in app/Util/ActivityPub/Helpers.php - About 4 hrs to fix

                    File Status.php has 346 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    <?php
                    
                    namespace App;
                    
                    use Auth, Cache, Hashids, Storage;
                    Severity: Minor
                    Found in app/Status.php - About 4 hrs to fix

                      Status has 33 functions (exceeds 20 allowed). Consider refactoring.
                      Open

                      class Status extends Model
                      {
                          use HasSnowflakePrimary, SoftDeletes;
                      
                          /**
                      Severity: Minor
                      Found in app/Status.php - About 4 hrs to fix

                        Method handleDirectMessage has 104 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function handleDirectMessage()
                            {
                                $activity = $this->payload['object'];
                                $actor = $this->actorFirstOrCreate($this->payload['actor']);
                                $profile = Profile::whereNull('domain')
                        Severity: Major
                        Found in app/Util/ActivityPub/Inbox.php - About 4 hrs to fix
                          Severity
                          Category
                          Status
                          Source
                          Language