pixelfed/pixelfed

View on GitHub

Showing 209 of 209 total issues

Function statusFirstOrFetch has a Cognitive Complexity of 62 (exceeds 5 allowed). Consider refactoring.
Open

    public static function statusFirstOrFetch($url, $replyTo = false)
    {
        $url = self::validateUrl($url);
        if($url == false) {
            return;
Severity: Minor
Found in app/Util/ActivityPub/Helpers.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File AccountController.php has 391 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace App\Http\Controllers;

use Auth; 
Severity: Minor
Found in app/Http/Controllers/AccountController.php - About 5 hrs to fix

    File Helpers.php has 387 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    namespace App\Util\ActivityPub;
    
    use DB, Cache, Purify, Storage, Request, Validator;
    Severity: Minor
    Found in app/Util/ActivityPub/Helpers.php - About 5 hrs to fix

      Profile has 38 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class Profile extends Model
      {
          use HasSnowflakePrimary, SoftDeletes;
      
          /**
      Severity: Minor
      Found in app/Profile.php - About 5 hrs to fix

        File web.php has 374 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
        
        Route::domain(config('pixelfed.domain.admin'))->prefix('i/admin')->group(function () {
            Route::redirect('/', '/dashboard');
            Route::redirect('timeline', config('app.url').'/timeline');
        Severity: Minor
        Found in routes/web.php - About 5 hrs to fix

          Method statusFirstOrFetch has 111 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public static function statusFirstOrFetch($url, $replyTo = false)
              {
                  $url = self::validateUrl($url);
                  if($url == false) {
                      return;
          Severity: Major
          Found in app/Util/ActivityPub/Helpers.php - About 4 hrs to fix

            File Status.php has 342 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
            
            namespace App;
            
            use Auth, Cache, Hashids, Storage;
            Severity: Minor
            Found in app/Status.php - About 4 hrs to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      try {
                          $notification = new Notification;
                          $notification->profile_id = $target->id;
                          $notification->actor_id = $actor->id;
                          $notification->action = 'share';
              Severity: Major
              Found in app/Jobs/SharePipeline/SharePipeline.php and 1 other location - About 4 hrs to fix
              app/Jobs/FollowPipeline/FollowPipeline.php on lines 53..70

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 137.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      try {
                          $notification = new Notification();
                          $notification->profile_id = $target->id;
                          $notification->actor_id = $actor->id;
                          $notification->action = 'follow';
              Severity: Major
              Found in app/Jobs/FollowPipeline/FollowPipeline.php and 1 other location - About 4 hrs to fix
              app/Jobs/SharePipeline/SharePipeline.php on lines 76..92

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 137.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Status has 32 functions (exceeds 20 allowed). Consider refactoring.
              Open

              class Status extends Model
              {
                  use HasSnowflakePrimary, SoftDeletes;
              
                  /**
              Severity: Minor
              Found in app/Status.php - About 4 hrs to fix

                Function handleFollowRequest has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function handleFollowRequest($item, $force)
                    {
                        $user = Auth::user()->profile;
                
                        $target = Profile::where('id', '!=', $user->id)->whereNull('status')->findOrFail($item);
                Severity: Minor
                Found in app/Http/Controllers/FollowerController.php - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method transform has 92 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function transform(Status $status)
                    {
                
                        $mentions = $status->mentions->map(function ($mention) {
                            $webfinger = $mention->emailUrl();
                Severity: Major
                Found in app/Transformer/ActivityPub/Verb/CreateNote.php - About 3 hrs to fix

                  Function handle has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function handle()
                      {
                          $this->info('Collecting data ...');
                  
                          $affected = collect([]);
                  Severity: Minor
                  Found in app/Console/Commands/FixUsernames.php - About 3 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  File home.blade.php has 315 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  @extends('admin.partial.template-full')
                  
                  @section('section')
                  <div class="title">
                      <h3 class="font-weight-bold d-inline-block">Profiles</h3>
                  Severity: Minor
                  Found in resources/views/admin/profiles/home.blade.php - About 3 hrs to fix

                    Method transform has 84 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function transform(Status $status)
                        {
                    
                            $mentions = $status->mentions->map(function ($mention) {
                                $webfinger = $mention->emailUrl();
                    Severity: Major
                    Found in app/Transformer/ActivityPub/Verb/Note.php - About 3 hrs to fix

                      File BaseApiController.php has 297 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      <?php
                      
                      namespace App\Http\Controllers\Api;
                      
                      use Illuminate\Http\Request;
                      Severity: Minor
                      Found in app/Http/Controllers/Api/BaseApiController.php - About 3 hrs to fix

                        Method handleImageTransform has 78 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function handleImageTransform(Media $media, $thumbnail = false)
                            {
                                $path = $media->media_path;
                                $file = storage_path('app/'.$path);
                                if (!in_array($media->mime, $this->acceptedMimes)) {
                        Severity: Major
                        Found in app/Util/Media/Image.php - About 3 hrs to fix

                          Function normalizeAudience has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public static function normalizeAudience($data, $localOnly = true)
                              {
                                  if(!isset($data['to'])) {
                                      return;
                                  }
                          Severity: Minor
                          Found in app/Util/ActivityPub/Helpers.php - About 3 hrs to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                          <?php
                          
                          namespace App\Observers;
                          
                          use App\StatusHashtag;
                          Severity: Major
                          Found in app/Observers/StatusHashtagObserver.php and 1 other location - About 3 hrs to fix
                          app/Observers/NotificationObserver.php on lines 1..64

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 119.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                          <?php
                          
                          namespace App\Observers;
                          
                          use App\Notification;
                          Severity: Major
                          Found in app/Observers/NotificationObserver.php and 1 other location - About 3 hrs to fix
                          app/Observers/StatusHashtagObserver.php on lines 1..64

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 119.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Severity
                          Category
                          Status
                          Source
                          Language