pixelfed/pixelfed

View on GitHub

Showing 513 of 615 total issues

File ApiV1Controller.php has 1460 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace App\Http\Controllers\Api;

use Illuminate\Http\Request;
Severity: Major
Found in app/Http/Controllers/Api/ApiV1Controller.php - About 3 days to fix

    File Inbox.php has 835 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    namespace App\Util\ActivityPub;
    
    use Cache, DB, Log, Purify, Redis, Storage, Validator;
    Severity: Major
    Found in app/Util/ActivityPub/Inbox.php - About 2 days to fix

      File DirectMessageController.php has 712 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
      
      namespace App\Http\Controllers;
      
      use Auth, Cache;
      Severity: Major
      Found in app/Http/Controllers/DirectMessageController.php - About 1 day to fix

        File PublicApiController.php has 673 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
        
        namespace App\Http\Controllers;
        
        use Illuminate\Http\Request;
        Severity: Major
        Found in app/Http/Controllers/PublicApiController.php - About 1 day to fix

          File polyfill.js has 634 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          /* Blob.js
           * A Blob, File, FileReader & URL implementation.
           * 2019-04-19
           *
           * By Eli Grey, http://eligrey.com
          Severity: Major
          Found in resources/assets/js/polyfill.js - About 1 day to fix

            File ComposeController.php has 610 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
            
            namespace App\Http\Controllers;
            
            use Illuminate\Http\Request;
            Severity: Major
            Found in app/Http/Controllers/ComposeController.php - About 1 day to fix

              Method browse has 249 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function browse(Request $request)
                  {
                      $this->validate($request, [
                          'a' => 'nullable|string|in:inbox,sent,filtered',
                          'page' => 'nullable|integer|min:1|max:99'
              Severity: Major
              Found in app/Http/Controllers/DirectMessageController.php - About 1 day to fix

                File Helpers.php has 542 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                <?php
                
                namespace App\Util\ActivityPub;
                
                use DB, Cache, Purify, Storage, Request, Validator;
                Severity: Major
                Found in app/Util/ActivityPub/Helpers.php - About 1 day to fix

                  Function FakeBlobBuilder has 200 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    function FakeBlobBuilder () {
                      function isDataView (obj) {
                        return obj && DataView.prototype.isPrototypeOf(obj)
                      }
                      function bufferClone (buf) {
                  Severity: Major
                  Found in resources/assets/js/polyfill.js - About 1 day to fix

                    File AccountController.php has 477 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    <?php
                    
                    namespace App\Http\Controllers;
                    
                    use Auth;
                    Severity: Minor
                    Found in app/Http/Controllers/AccountController.php - About 7 hrs to fix

                      ApiV1Controller has 52 functions (exceeds 20 allowed). Consider refactoring.
                      Open

                      class ApiV1Controller extends Controller
                      {
                          protected $fractal;
                      
                          public function __construct()
                      Severity: Major
                      Found in app/Http/Controllers/Api/ApiV1Controller.php - About 7 hrs to fix

                        File web.php has 471 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        <?php
                        
                        Route::domain(config('pixelfed.domain.admin'))->prefix('i/admin')->group(function () {
                            Route::redirect('/', '/dashboard');
                            Route::redirect('timeline', config('app.url').'/timeline');
                        Severity: Minor
                        Found in routes/web.php - About 7 hrs to fix

                          Function statusFirstOrFetch has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public static function statusFirstOrFetch($url, $replyTo = false)
                              {
                                  $url = self::validateUrl($url);
                                  if($url == false) {
                                      return;
                          Severity: Minor
                          Found in app/Util/ActivityPub/Helpers.php - About 7 hrs to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method getData has 173 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function getData(Request $request)
                              {
                                  abort_if(now()->gt('2021-03-01 00:00:00'), 404);
                                  abort_if(config('database.default') != 'mysql', 404);
                          
                          
                          Severity: Major
                          Found in app/Http/Controllers/SeasonalController.php - About 6 hrs to fix

                            Method modAction has 156 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public function modAction(Request $request)
                                {
                                    abort_unless(Auth::user()->is_admin, 400);
                                    $this->validate($request, [
                                        'action' => [
                            Severity: Major
                            Found in app/Http/Controllers/InternalApiController.php - About 6 hrs to fix

                              File StoryComposeController.php has 417 lines of code (exceeds 250 allowed). Consider refactoring.
                              Open

                              <?php
                              
                              namespace App\Http\Controllers;
                              
                              use Illuminate\Http\Request;
                              Severity: Minor
                              Found in app/Http/Controllers/StoryComposeController.php - About 6 hrs to fix

                                Method statusFirstOrFetch has 150 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                    public static function statusFirstOrFetch($url, $replyTo = false)
                                    {
                                        $url = self::validateUrl($url);
                                        if($url == false) {
                                            return;
                                Severity: Major
                                Found in app/Util/ActivityPub/Helpers.php - About 6 hrs to fix

                                  File InternalApiController.php has 409 lines of code (exceeds 250 allowed). Consider refactoring.
                                  Open

                                  <?php
                                  
                                  namespace App\Http\Controllers;
                                  
                                  use Illuminate\Http\Request;
                                  Severity: Minor
                                  Found in app/Http/Controllers/InternalApiController.php - About 5 hrs to fix

                                    Function statusCreate has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
                                    Open

                                        public function statusCreate(Request $request)
                                        {
                                            abort_if(!$request->user(), 403);
                                    
                                            $this->validate($request, [
                                    Severity: Minor
                                    Found in app/Http/Controllers/Api/ApiV1Controller.php - About 5 hrs to fix

                                    Cognitive Complexity

                                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                    A method's cognitive complexity is based on a few simple rules:

                                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                    • Code is considered more complex for each "break in the linear flow of the code"
                                    • Code is considered more complex when "flow breaking structures are nested"

                                    Further reading

                                    Function settingsHomeStore has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
                                    Open

                                        public function settingsHomeStore(Request $request)
                                        {
                                            $this->validate($request, [
                                                'name' => 'nullable|string',
                                                'short_description' => 'nullable',
                                    Severity: Minor
                                    Found in app/Http/Controllers/Admin/AdminSettingsController.php - About 5 hrs to fix

                                    Cognitive Complexity

                                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                    A method's cognitive complexity is based on a few simple rules:

                                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                    • Code is considered more complex for each "break in the linear flow of the code"
                                    • Code is considered more complex when "flow breaking structures are nested"

                                    Further reading

                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language