pixelfed/pixelfed

View on GitHub

Showing 358 of 443 total issues

File DirectMessageController.php has 709 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace App\Http\Controllers;

use Auth, Cache;
Severity: Major
Found in app/Http/Controllers/DirectMessageController.php - About 1 day to fix

    File PublicApiController.php has 678 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    namespace App\Http\Controllers;
    
    use Illuminate\Http\Request;
    Severity: Major
    Found in app/Http/Controllers/PublicApiController.php - About 1 day to fix

      File polyfill.js has 634 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /* Blob.js
       * A Blob, File, FileReader & URL implementation.
       * 2019-04-19
       *
       * By Eli Grey, http://eligrey.com
      Severity: Major
      Found in resources/assets/js/polyfill.js - About 1 day to fix

        Method browse has 249 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function browse(Request $request)
            {
                $this->validate($request, [
                    'a' => 'nullable|string|in:inbox,sent,filtered',
                    'page' => 'nullable|integer|min:1|max:99'
        Severity: Major
        Found in app/Http/Controllers/DirectMessageController.php - About 1 day to fix

          File ComposeController.php has 549 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
          
          namespace App\Http\Controllers;
          
          use Illuminate\Http\Request;
          Severity: Major
          Found in app/Http/Controllers/ComposeController.php - About 1 day to fix

            File Inbox.php has 528 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
            
            namespace App\Util\ActivityPub;
            
            use Cache, DB, Log, Purify, Redis, Validator;
            Severity: Major
            Found in app/Util/ActivityPub/Inbox.php - About 1 day to fix

              Function FakeBlobBuilder has 200 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                function FakeBlobBuilder () {
                  function isDataView (obj) {
                    return obj && DataView.prototype.isPrototypeOf(obj)
                  }
                  function bufferClone (buf) {
              Severity: Major
              Found in resources/assets/js/polyfill.js - About 1 day to fix

                File AccountController.php has 477 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                <?php
                
                namespace App\Http\Controllers;
                
                use Auth;
                Severity: Minor
                Found in app/Http/Controllers/AccountController.php - About 7 hrs to fix

                  File Helpers.php has 474 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  <?php
                  
                  namespace App\Util\ActivityPub;
                  
                  use DB, Cache, Purify, Storage, Request, Validator;
                  Severity: Minor
                  Found in app/Util/ActivityPub/Helpers.php - About 7 hrs to fix

                    Method getData has 173 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function getData(Request $request)
                        {
                            abort_if(now()->gt('2021-03-01 00:00:00'), 404);
                            abort_if(config('database.default') != 'mysql', 404);
                    
                    
                    Severity: Major
                    Found in app/Http/Controllers/SeasonalController.php - About 6 hrs to fix

                      File web.php has 450 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      <?php
                      
                      Route::domain(config('pixelfed.domain.admin'))->prefix('i/admin')->group(function () {
                          Route::redirect('/', '/dashboard');
                          Route::redirect('timeline', config('app.url').'/timeline');
                      Severity: Minor
                      Found in routes/web.php - About 6 hrs to fix

                        Function statusFirstOrFetch has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public static function statusFirstOrFetch($url, $replyTo = false)
                            {
                                $url = self::validateUrl($url);
                                if($url == false) {
                                    return;
                        Severity: Minor
                        Found in app/Util/ActivityPub/Helpers.php - About 6 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method statusFirstOrFetch has 135 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public static function statusFirstOrFetch($url, $replyTo = false)
                            {
                                $url = self::validateUrl($url);
                                if($url == false) {
                                    return;
                        Severity: Major
                        Found in app/Util/ActivityPub/Helpers.php - About 5 hrs to fix

                          Profile has 38 functions (exceeds 20 allowed). Consider refactoring.
                          Open

                          class Profile extends Model
                          {
                              use HasSnowflakePrimary, SoftDeletes;
                          
                              /**
                          Severity: Minor
                          Found in app/Profile.php - About 5 hrs to fix

                            Method store has 118 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public function store(Request $request)
                                {
                                    $this->validate($request, [
                                        'caption' => 'nullable|string|max:'.config('pixelfed.max_caption_length', 500),
                                        'media.*'   => 'required',
                            Severity: Major
                            Found in app/Http/Controllers/ComposeController.php - About 4 hrs to fix

                              File StatusController.php has 354 lines of code (exceeds 250 allowed). Consider refactoring.
                              Open

                              <?php
                              
                              namespace App\Http\Controllers;
                              
                              use App\Jobs\ImageOptimizePipeline\ImageOptimize;
                              Severity: Minor
                              Found in app/Http/Controllers/StatusController.php - About 4 hrs to fix

                                Method accountStatuses has 111 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                    public function accountStatuses(Request $request, $id)
                                    {
                                        $this->validate($request, [
                                            'only_media' => 'nullable',
                                            'pinned' => 'nullable',
                                Severity: Major
                                Found in app/Http/Controllers/PublicApiController.php - About 4 hrs to fix

                                  Function handleDirectMessage has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
                                  Open

                                      public function handleDirectMessage()
                                      {
                                          $activity = $this->payload['object'];
                                          $actor = $this->actorFirstOrCreate($this->payload['actor']);
                                          $profile = Profile::whereNull('domain')
                                  Severity: Minor
                                  Found in app/Util/ActivityPub/Inbox.php - About 4 hrs to fix

                                  Cognitive Complexity

                                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                  A method's cognitive complexity is based on a few simple rules:

                                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                  • Code is considered more complex for each "break in the linear flow of the code"
                                  • Code is considered more complex when "flow breaking structures are nested"

                                  Further reading

                                  File Status.php has 345 lines of code (exceeds 250 allowed). Consider refactoring.
                                  Open

                                  <?php
                                  
                                  namespace App;
                                  
                                  use Auth, Cache, Hashids, Storage;
                                  Severity: Minor
                                  Found in app/Status.php - About 4 hrs to fix

                                    Status has 33 functions (exceeds 20 allowed). Consider refactoring.
                                    Open

                                    class Status extends Model
                                    {
                                        use HasSnowflakePrimary, SoftDeletes;
                                    
                                        /**
                                    Severity: Minor
                                    Found in app/Status.php - About 4 hrs to fix
                                      Severity
                                      Category
                                      Status
                                      Source
                                      Language