pixelfederation/swoole-bundle

View on GitHub
src/Server/HttpServerConfiguration.php

Summary

Maintainability
C
1 day
Test Coverage

HttpServerConfiguration has 34 functions (exceeds 20 allowed). Consider refactoring.
Open

class HttpServerConfiguration
{
    private const SWOOLE_HTTP_SERVER_CONFIG_DAEMONIZE = 'daemonize';
    private const SWOOLE_HTTP_SERVER_CONFIG_SERVE_STATIC = 'serve_static';
    private const SWOOLE_HTTP_SERVER_CONFIG_REACTOR_COUNT = 'reactor_count';
Severity: Minor
Found in src/Server/HttpServerConfiguration.php - About 4 hrs to fix

    File HttpServerConfiguration.php has 306 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    declare(strict_types=1);
    
    namespace K911\Swoole\Server;
    Severity: Minor
    Found in src/Server/HttpServerConfiguration.php - About 3 hrs to fix

      The class HttpServerConfiguration has an overall complexity of 67 which is very high. The configured complexity threshold is 50.
      Open

      class HttpServerConfiguration
      {
          private const SWOOLE_HTTP_SERVER_CONFIG_DAEMONIZE = 'daemonize';
          private const SWOOLE_HTTP_SERVER_CONFIG_SERVE_STATIC = 'serve_static';
          private const SWOOLE_HTTP_SERVER_CONFIG_REACTOR_COUNT = 'reactor_count';

      Method validateSetting has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function validateSetting(string $key, mixed $value): void
          {
              Assertion::keyExists(self::SWOOLE_HTTP_SERVER_CONFIGURATION, $key, 'There is no configuration mapping for setting "%s".');
      
              switch ($key) {
      Severity: Major
      Found in src/Server/HttpServerConfiguration.php - About 2 hrs to fix

        Function validateSetting has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            private function validateSetting(string $key, mixed $value): void
            {
                Assertion::keyExists(self::SWOOLE_HTTP_SERVER_CONFIGURATION, $key, 'There is no configuration mapping for setting "%s".');
        
                switch ($key) {
        Severity: Minor
        Found in src/Server/HttpServerConfiguration.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        The method validateSetting() has a Cyclomatic Complexity of 17. The configured cyclomatic complexity threshold is 10.
        Open

            private function validateSetting(string $key, mixed $value): void
            {
                Assertion::keyExists(self::SWOOLE_HTTP_SERVER_CONFIGURATION, $key, 'There is no configuration mapping for setting "%s".');
        
                switch ($key) {

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
        class Foo {
        1   public function example() {
        2       if ($a == $b) {
        3           if ($a1 == $b1) {
                        fiddle();
        4           } elseif ($a2 == $b2) {
                        fiddle();
                    } else {
                        fiddle();
                    }
        5       } elseif ($c == $d) {
        6           while ($c == $d) {
                        fiddle();
                    }
        7        } elseif ($e == $f) {
        8           for ($n = 0; $n < $h; $n++) {
                        fiddle();
                    }
                } else {
                    switch ($z) {
        9               case 1:
                            fiddle();
                            break;
        10              case 2:
                            fiddle();
                            break;
        11              case 3:
                            fiddle();
                            break;
                        default:
                            fiddle();
                            break;
                    }
                }
            }
        }

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        Line indented incorrectly; expected 4 spaces, found 8
        Open

                private ?int $maxConcurrency = null

        Line indented incorrectly; expected 4 spaces, found 8
        Open

                private Sockets $sockets,

        Line indented incorrectly; expected 4 spaces, found 8
        Open

                private string $runningMode = 'process',

        There are no issues that match your filters.

        Category
        Status