Sign upLogin

planio-gmbh/rackstash

View on GitHub
Star

Showing 6 of 6 total issues

Method perform_action_with_rackstash has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

      def perform_action_with_rackstash
        if logger
          rackstash_fields = {
            :controller => params["controller"],
            :action => params["action"],
Severity: Minor
Found in lib/rackstash/rails_ext/action_controller.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class BufferedLogger has 29 methods (exceeds 20 allowed). Consider refactoring.
Open

  class BufferedLogger
    extend Forwardable
    include Rackstash::LogSeverity

    class SimpleFormatter < ::Logger::Formatter
Severity: Minor
Found in lib/rackstash/buffered_logger.rb - About 3 hrs to fix

    Method perform_action_with_rackstash has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def perform_action_with_rackstash
        if logger
          rackstash_fields = {
            :controller => params["controller"],
            :action => params["action"],
    Severity: Minor
    Found in lib/rackstash/rails_ext/action_controller.rb - About 1 hr to fix

      Method setup has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

            def setup(config={})
        super

        unless Rails.logger.is_a?(Rackstash::BufferedLogger)
          # This is required by ActiveRecord >= 4
      Severity: Minor
      Found in lib/rackstash/framework/rails3.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method flush_and_pop_buffer has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          def flush_and_pop_buffer
      if buffer = self.buffer
        unless buffer[:do_not_log]
          json = logstash_event(buffer[:messages], buffer[:fields], buffer[:tags])
          log_level = Rackstash.respond_to?(:log_level) ? Rackstash.log_level : :info
      Severity: Minor
      Found in lib/rackstash/buffered_logger.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method add has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          def add(severity, message=nil, progname=nil)
      severity ||= UNKNOWN
      return true if level > severity

      progname ||= logger.progname if logger.respond_to?(:progname)
      Severity: Minor
      Found in lib/rackstash/buffered_logger.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language