platanus/angular-restmod

View on GitHub

Showing 14 of 33 total issues

Function exports has 191 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(grunt) {

  // Project configuration.
  grunt.initConfig({
    pkg: grunt.file.readJSON('bower.json'),
Severity: Major
Found in Gruntfile.js - About 7 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if(typeof _model === 'string') {
              _model = $injector.get(_model);
    
              // retrieve global options
              options = _model.getProperty('hasMany', {});
    Severity: Major
    Found in src/module/extended/builder-relations.js and 1 other location - About 4 hrs to fix
    src/module/extended/builder-relations.js on lines 127..141

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 123.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if(typeof _model === 'string') {
              _model = $injector.get(_model);
    
              // retrieve global options
              options = _model.getProperty('hasOne', {});
    Severity: Major
    Found in src/module/extended/builder-relations.js and 1 other location - About 4 hrs to fix
    src/module/extended/builder-relations.js on lines 62..76

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 123.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          } else if(_value !== null && typeof _value === 'object' && typeof _value.toJSON !== 'function') {
            // IDEA: make deep decoding/encoding optional, could be a little taxing for some apps
            if(isArray(_value)) {
              result = [];
              for(var i = 0, l = _value.length; i < l; i++) {
    Severity: Major
    Found in src/module/serializer.js and 1 other location - About 3 hrs to fix
    src/module/serializer.js on lines 100..111

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 110.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          } else if(typeof _value === 'object') {
            // IDEA: make extended decoding/encoding optional, could be a little taxing for some apps
            if(isArray(_value)) {
              result = [];
              for(var i = 0, l = _value.length; i < l; i++) {
    Severity: Major
    Found in src/module/serializer.js and 1 other location - About 3 hrs to fix
    src/module/serializer.js on lines 164..175

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 110.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function exports has 80 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function(config) {
      config.set({
    
        // Base path, that will be used to resolve files and exclude
        basePath: '',
    Severity: Major
    Found in karma-sauce.conf.js - About 3 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                attrDecoder: function(_attr, _filter, _filterParam, _chain) {
      
                  if(typeof _filter === 'string') {
                    var filter = $filter(_filter);
                    _filter = function(_value) { return filter(_value, _filterParam); };
      Severity: Major
      Found in src/module/serializer.js and 1 other location - About 2 hrs to fix
      src/module/serializer.js on lines 301..310

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 94.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                attrEncoder: function(_attr, _filter, _filterParam, _chain) {
      
                  if(typeof _filter === 'string') {
                    var filter = $filter(_filter);
                    _filter = function(_value) { return filter(_value, _filterParam); };
      Severity: Major
      Found in src/module/serializer.js and 1 other location - About 2 hrs to fix
      src/module/serializer.js on lines 279..288

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 94.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function Builder has 69 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        function Builder(_baseDsl) {
      
          var mappings = [
            { fun: 'attrDefault', sign: ['init'] },
            { fun: 'attrMask', sign: ['ignore'] },
      Severity: Major
      Found in src/module/builder.js - About 2 hrs to fix

        Function $save has 56 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            $save: function(_patch) {
              return this.$action(function() {
                var url = this.$url('update'), request;
        
                if(url) {
        Severity: Major
        Found in src/module/api/record-api.js - About 2 hrs to fix

          Function attrAsCollection has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              attrAsCollection: function(_attr, _model, _url, _source, _inverseOf, _params, _hooks) {
          Severity: Major
          Found in src/module/extended/builder-relations.js - About 50 mins to fix

            Avoid deeply nested control flow statements.
            Open

                          for(var key in _desc) {
                            if(_desc.hasOwnProperty(key)) this.on(key, _desc[key]);
                          }
            Severity: Major
            Found in src/module/builder.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                              if(_desc.hasOwnProperty(key)) this.define(key, _desc[key]);
              Severity: Major
              Found in src/module/builder.js - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                            } else if(VAR_RGX.test(_attr)) {
                              $log.warn('Usage of ~ in description objects will be removed in 1.2, use a $config block instead');
                              _attr = inflector.camelize(_attr.toLowerCase());
                              this.setProperty(_attr, _desc);
                            }
                Severity: Major
                Found in src/module/builder.js - About 45 mins to fix
                  Severity
                  Category
                  Status
                  Source
                  Language