Showing 19 of 33 total issues
Function dsl
has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
dsl: function() {
return {
/**
Function attrAsReferenceToMany
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
attrAsReferenceToMany: function(_attr, _model, _keys) {
this.attrDefault(_attr, function() { return []; })
.attrMask(_attr, Utils.WRITE_MASK)
.attrMeta(_attr, { relation: 'belongs_to_many' });
Function attrAsReference
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
attrAsReference: function(_attr, _model, _key, _prefetch) {
this.attrDefault(_attr, null)
.attrMask(_attr, Utils.WRITE_MASK)
.attrMeta(_attr, { relation: 'belongs_to' });
Function decode
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
function decode(_from, _to, _prefix, _mask, _ctx) {
var key, decodedName, fullName, value, maps, isMapped, i, l,
prefix = _prefix ? _prefix + '.' : '';
// explicit mappings
Function describe
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
describe: function(_description) {
forEach(_description, function(_desc, _attr) {
switch(_attr.charAt(0)) {
case '@':
$log.warn('Usage of @ in description objects will be removed in 1.2, use a $extend block instead');
Function attrAsCollection
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
attrAsCollection: function(_attr, _model, _url, _source, _inverseOf, _params, _hooks) {
var options, globalHooks; // global relation configuration
this.attrDefault(_attr, function() {
Function buildArrayType
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
buildArrayType: function(_forceIframe) {
var arrayType;
if(PROTO_SETTER && !_forceIframe) {
Function $send
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
$send: function(_options, _success, _error) {
// make sure a style base was selected for the model
if(!this.$type.getProperty('style')) {
$log.warn('No API style base was selected, see the Api Integration FAQ for more information on this warning');
Function define
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
define: function(_where, _fun) {
var name = false, api = 'Record';
if(typeof _fun === 'object' && _fun) {
api = _where;
Function attrAsResource
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
attrAsResource: function(_attr, _model, _url, _source, _inverseOf, _hooks) {
var options, globalHooks; // global relation configuration
this.attrDefault(_attr, function() {
Function exports
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
module.exports = function(config) {
config.set({
// Base path, that will be used to resolve files and exclude
basePath: '',
Function encode
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
function encode(_from, _to, _prefix, _mask, _ctx) {
var key, fullName, encodedName, value, maps,
prefix = _prefix ? _prefix + '.' : '';
// implicit mappings
Function attrAsResource
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
attrAsResource: function(_attr, _model, _url, _source, _inverseOf, _hooks) {
Function processFeature
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
function processFeature(_raw, _name, _feature, _other, _do) {
Function decode
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
function decode(_from, _to, _prefix, _mask, _ctx) {
Function encode
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
function encode(_from, _to, _prefix, _mask, _ctx) {
Similar blocks of code found in 3 locations. Consider refactoring. Open
if(_attr === '$config') { // configuration block
for(var key in _desc) {
if(_desc.hasOwnProperty(key)) this.setProperty(key, _desc[key]);
}
} else if(_attr === '$extend') { // extension block
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 47.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 3 locations. Consider refactoring. Open
} else if(_attr === '$extend') { // extension block
for(var key in _desc) {
if(_desc.hasOwnProperty(key)) this.define(key, _desc[key]);
}
} else if(_attr === '$hooks') { // hooks block
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 47.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 3 locations. Consider refactoring. Open
} else if(_attr === '$hooks') { // hooks block
for(var key in _desc) {
if(_desc.hasOwnProperty(key)) this.on(key, _desc[key]);
}
} else if(VAR_RGX.test(_attr)) {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 47.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76