platanus/angular-restmod

View on GitHub
src/module/builder.js

Summary

Maintainability
C
1 day
Test Coverage

Function Builder has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function Builder(_baseDsl) {

    var mappings = [
      { fun: 'attrDefault', sign: ['init'] },
      { fun: 'attrMask', sign: ['ignore'] },
Severity: Major
Found in src/module/builder.js - About 2 hrs to fix

    Function describe has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          describe: function(_description) {
            forEach(_description, function(_desc, _attr) {
              switch(_attr.charAt(0)) {
              case '@':
                $log.warn('Usage of @ in description objects will be removed in 1.2, use a $extend block instead');
    Severity: Minor
    Found in src/module/builder.js - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                      if(_desc.hasOwnProperty(key)) this.define(key, _desc[key]);
      Severity: Major
      Found in src/module/builder.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                      for(var key in _desc) {
                        if(_desc.hasOwnProperty(key)) this.on(key, _desc[key]);
                      }
        Severity: Major
        Found in src/module/builder.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                      } else if(VAR_RGX.test(_attr)) {
                        $log.warn('Usage of ~ in description objects will be removed in 1.2, use a $config block instead');
                        _attr = inflector.camelize(_attr.toLowerCase());
                        this.setProperty(_attr, _desc);
                      }
          Severity: Major
          Found in src/module/builder.js - About 45 mins to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                        if(_attr === '$config') { // configuration block
                          for(var key in _desc) {
                            if(_desc.hasOwnProperty(key)) this.setProperty(key, _desc[key]);
                          }
                        } else if(_attr === '$extend') { // extension block
            Severity: Minor
            Found in src/module/builder.js and 2 other locations - About 35 mins to fix
            src/module/builder.js on lines 215..230
            src/module/builder.js on lines 219..230

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                        } else if(_attr === '$extend') { // extension block
                          for(var key in _desc) {
                            if(_desc.hasOwnProperty(key)) this.define(key, _desc[key]);
                          }
                        } else if(_attr === '$hooks') { // hooks block
            Severity: Minor
            Found in src/module/builder.js and 2 other locations - About 35 mins to fix
            src/module/builder.js on lines 211..230
            src/module/builder.js on lines 219..230

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                        } else if(_attr === '$hooks') { // hooks block
                          for(var key in _desc) {
                            if(_desc.hasOwnProperty(key)) this.on(key, _desc[key]);
                          }
                        } else if(VAR_RGX.test(_attr)) {
            Severity: Minor
            Found in src/module/builder.js and 2 other locations - About 35 mins to fix
            src/module/builder.js on lines 211..230
            src/module/builder.js on lines 215..230

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status