platanus/angular-restmod

View on GitHub
src/module/extended/builder-relations.js

Summary

Maintainability
D
1 day
Test Coverage

Function attrAsReferenceToMany has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    attrAsReferenceToMany: function(_attr, _model, _keys) {

      this.attrDefault(_attr, function() { return []; })
          .attrMask(_attr, Utils.WRITE_MASK)
          .attrMeta(_attr, { relation: 'belongs_to_many' });
Severity: Minor
Found in src/module/extended/builder-relations.js - About 1 hr to fix

    Function attrAsReference has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        attrAsReference: function(_attr, _model, _key, _prefetch) {
    
          this.attrDefault(_attr, null)
              .attrMask(_attr, Utils.WRITE_MASK)
              .attrMeta(_attr, { relation: 'belongs_to' });
    Severity: Minor
    Found in src/module/extended/builder-relations.js - About 1 hr to fix

      Function attrAsCollection has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          attrAsCollection: function(_attr, _model, _url, _source, _inverseOf, _params, _hooks) {
      
            var options, globalHooks; // global relation configuration
      
            this.attrDefault(_attr, function() {
      Severity: Minor
      Found in src/module/extended/builder-relations.js - About 1 hr to fix

        Function attrAsResource has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            attrAsResource: function(_attr, _model, _url, _source, _inverseOf, _hooks) {
        
              var options, globalHooks; // global relation configuration
        
              this.attrDefault(_attr, function() {
        Severity: Minor
        Found in src/module/extended/builder-relations.js - About 1 hr to fix

          Function attrAsCollection has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              attrAsCollection: function(_attr, _model, _url, _source, _inverseOf, _params, _hooks) {
          Severity: Major
          Found in src/module/extended/builder-relations.js - About 50 mins to fix

            Function attrAsResource has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                attrAsResource: function(_attr, _model, _url, _source, _inverseOf, _hooks) {
            Severity: Minor
            Found in src/module/extended/builder-relations.js - About 45 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if(typeof _model === 'string') {
                        _model = $injector.get(_model);
              
                        // retrieve global options
                        options = _model.getProperty('hasOne', {});
              Severity: Major
              Found in src/module/extended/builder-relations.js and 1 other location - About 4 hrs to fix
              src/module/extended/builder-relations.js on lines 62..76

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 123.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if(typeof _model === 'string') {
                        _model = $injector.get(_model);
              
                        // retrieve global options
                        options = _model.getProperty('hasMany', {});
              Severity: Major
              Found in src/module/extended/builder-relations.js and 1 other location - About 4 hrs to fix
              src/module/extended/builder-relations.js on lines 127..141

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 123.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status