Sign upLogin

pluf/shop

View on GitHub
Star
src/Shop/Service.php

Summary

Maintainability
A
0 mins
Test Coverage

Define a constant instead of duplicating this literal "relate_name" 3 times.
Open

                'relate_name' => 'services',
Severity: Critical
Found in src/Shop/Service.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "taxes" 3 times.
Open

            'taxes' => array(
Severity: Critical
Found in src/Shop/Service.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "services" 3 times.
Open

                'relate_name' => 'services',
Severity: Critical
Found in src/Shop/Service.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class Shop_Service extends Shop_PricedObject
Severity: Minor
Found in src/Shop/Service.php by phpcodesniffer

The class Shop_Service is not named in CamelCase.
Open

class Shop_Service extends Shop_PricedObject
{

    /**
     *
Severity: Minor
Found in src/Shop/Service.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Visibility must be declared on method "init"
Open

    function init()
Severity: Minor
Found in src/Shop/Service.php by phpcodesniffer

Class name "Shop_Service" is not in camel caps format
Open

class Shop_Service extends Shop_PricedObject
Severity: Minor
Found in src/Shop/Service.php by phpcodesniffer

There are no issues that match your filters.

Category
Status