Sign upLogin

pluswerk/secure_login

View on GitHub
Star

Showing 8 of 8 total issues

Function getBlockade has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public function getBlockade($username, $authKey = '', array $types = null, $timestamp = null, $setPublicBlockade = true)
    {
        $blockade = null;
        if ($types === null) {
            $types = [static::TYPE_USER, static::TYPE_IP];
Severity: Minor
Found in Classes/Service/AuthSecurityService.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method logFailedAttempt has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function logFailedAttempt($authIdentifier, $hashedFailureValue, $type, $authKey, $timestamp = null)
    {
        if ($timestamp === null) {
            $timestamp = time();
        }
Severity: Minor
Found in Classes/Persistence/DatabaseHandler.php - About 1 hr to fix

    Function logUserPasswordAuthenticationFailed has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        public function logUserPasswordAuthenticationFailed(
        $username,
        $password,
        $authKey = '',
        array $types = null,
    Severity: Minor
    Found in Classes/Service/AuthSecurityService.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method logUserPasswordAuthenticationFailed has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            $username,
        $password,
        $authKey = '',
        array $types = null,
        $timestamp = null,
    Severity: Major
    Found in Classes/Service/AuthSecurityService.php - About 50 mins to fix

      Method addBlockade has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function addBlockade($type, $authKey, $authIdentifier, $reason, $blockingPeriodInSeconds, $timestamp = null)
      Severity: Minor
      Found in Classes/Persistence/DatabaseHandler.php - About 45 mins to fix

        Method getBlockade has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function getBlockade($username, $authKey = '', array $types = null, $timestamp = null, $setPublicBlockade = true)
        Severity: Minor
        Found in Classes/Service/AuthSecurityService.php - About 35 mins to fix

          Method logUserAuthenticationFailed has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  $username,
        $authKey = '',
        $timestamp = null,
        $createBlockade = true,
        BlockingConfiguration $configuration = null
          Severity: Minor
          Found in Classes/Service/AuthSecurityService.php - About 35 mins to fix

            Method logFailedAttempt has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function logFailedAttempt($authIdentifier, $hashedFailureValue, $type, $authKey, $timestamp = null)
            Severity: Minor
            Found in Classes/Persistence/DatabaseHandler.php - About 35 mins to fix
              Severity
              Category
              Status
              Source
              Language