poliastro/poliastro

View on GitHub

Showing 91 of 91 total issues

Cyclomatic complexity is too high in function izzo. (6)
Open

@jit
def izzo(k, r1, r2, tof, M, numiter, rtol):
    """ Aplies izzo algorithm to solve Lambert's problem.

    Parameters
Severity: Minor
Found in src/poliastro/core/iod.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Function danby has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

def danby(k, r0, v0, tof, numiter=20, rtol=1e-8):
    """ Kepler solver for both elliptic and parabolic orbits based on Danby's
    algorithm.

    Parameters
Severity: Minor
Found in src/poliastro/core/propagation.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function add_orbit has 18 arguments (exceeds 9 allowed). Consider refactoring.
Open

    def add_orbit(
Severity: Major
Found in src/poliastro/czml/extract_czml.py - About 1 hr to fix

    Function mikkola has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

    def mikkola(k, r0, v0, tof, rtol=None):
        """ Raw algorithm for Mikkola's Kepler solver.
    
        Parameters
        ----------
    Severity: Minor
    Found in src/poliastro/core/propagation.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function frozen has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        def frozen(
            cls,
            attractor,
            alt,
            inc=None,
    Severity: Minor
    Found in src/poliastro/twobody/orbit.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function vallado has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    def vallado(k, r0, r, tof, short, numiter, rtol):
        r"""Solves the Lambert's problem.
    
        The algorithm returns the initial velocity vector and the final one, these are
        computed by the following expresions:
    Severity: Minor
    Found in src/poliastro/core/iod.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __init__ has 14 arguments (exceeds 9 allowed). Consider refactoring.
    Open

        def __init__(
    Severity: Major
    Found in src/poliastro/integrators.py - About 1 hr to fix

      Function rv2coe has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      def rv2coe(k, r, v, tol=1e-8):
          r"""Converts from vectors to classical orbital elements.
      
          1. First the angular momentum is computed:
              .. math::
      Severity: Minor
      Found in src/poliastro/core/elements.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function add_ground_station has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def add_ground_station(
              self,
              pos,
              id_description=None,
              label_fill_color=None,
      Severity: Minor
      Found in src/poliastro/czml/extract_czml.py - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function change_attractor has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def change_attractor(self, new_attractor, force=False):
              """Changes orbit attractor.
      
              Only changes from attractor to parent or the other way around are allowed.
      
      
      Severity: Minor
      Found in src/poliastro/twobody/orbit.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function kepler has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      def kepler(k, r0, v0, tof, numiter):
          r"""Solves Kepler's Equation by applying a Newton-Raphson method.
      
          If the position of a body along its orbit wants to be computed
          for an specific time, it can be solved by terms of the Kepler's Equation:
      Severity: Minor
      Found in src/poliastro/core/propagation.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function __new__ has 11 arguments (exceeds 9 allowed). Consider refactoring.
      Open

          def __new__(
      Severity: Major
      Found in src/poliastro/bodies.py - About 45 mins to fix

        Function frozen has 10 arguments (exceeds 9 allowed). Consider refactoring.
        Open

            def frozen(
        Severity: Major
        Found in src/poliastro/twobody/orbit.py - About 35 mins to fix

          Function newton has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

          def newton(regime, x0, args=(), tol=1.48e-08, maxiter=50):
              p0 = 1.0 * x0
              for iter in range(maxiter):
                  if regime == "parabolic":
                      fval = _kepler_equation_parabolic(p0, *args)
          Severity: Minor
          Found in src/poliastro/core/angles.py - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function temperature has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def temperature(self, alt, geometric=True):
                  """ Solves for temperature at given altitude.
          
                  Parameters
                  ----------
          Severity: Minor
          Found in src/poliastro/atmosphere/coesa76.py - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function hyp2f1b has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

          def hyp2f1b(x):
              """Hypergeometric function 2F1(3, 1, 5/2, x), see [Battin].
          
              .. todo::
                  Add more information about this function
          Severity: Minor
          Found in src/poliastro/core/hyper.py - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _get_index has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              def _get_index(self, x, x_levels):
                  """ Finds element in list and returns index.
          
                  Parameters
                  ----------
          Severity: Minor
          Found in src/poliastro/atmosphere/base.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function hill_radius has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          def hill_radius(body, a=None, e=None):
              """Approximated radius of the Hill Sphere of Influence (SOI) for a body.
          
              Parameters
              ----------
          Severity: Minor
          Found in src/poliastro/threebody/soi.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function porkchop has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          def porkchop(
              departure_body,
              target_body,
              launch_span,
              arrival_span,
          Severity: Minor
          Found in src/poliastro/plotting/porkchop.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _find_xy has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          def _find_xy(ll, T, M, numiter, rtol):
              """Computes all x, y for given number of revolutions.
          
              """
              # For abs(ll) == 1 the derivative is not continuous
          Severity: Minor
          Found in src/poliastro/core/iod.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language