poliastro/poliastro

View on GitHub
src/poliastro/core/earth_atmosphere/jacchia.py

Summary

Maintainability
B
4 hrs
Test Coverage

Cyclomatic complexity is too high in function _altitude_profile. (20)
Open

@jit
def _altitude_profile(alt, Texo, x, y, E5M, E6P):
    # Raise Value Error if alt < 90 km or alt > 2500 km.
    if alt < 90 or 2500 < alt:
        raise ValueError("Jacchia77 has been implemented in range 90km - 2500km.")

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Function _altitude_profile has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

def _altitude_profile(alt, Texo, x, y, E5M, E6P):
    # Raise Value Error if alt < 90 km or alt > 2500 km.
    if alt < 90 or 2500 < alt:
        raise ValueError("Jacchia77 has been implemented in range 90km - 2500km.")

Severity: Minor
Found in src/poliastro/core/earth_atmosphere/jacchia.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity is too high in function _H_correction. (7)
Open

@jit
def _H_correction(alt, Texo, x, y, Z, CN2, CO2, CO, CAr, CHe, CH, CM, WM, T):
    phid00 = 10.0 ** (6.9 + 28.9 * Texo ** (-0.25)) / 2.0e20
    phid00 = phid00 * 5.24e2
    H_500 = 10.0 ** (-0.06 + 28.9 * Texo ** (-0.25))

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Function _H_correction has 14 arguments (exceeds 9 allowed). Consider refactoring.
Open

def _H_correction(alt, Texo, x, y, Z, CN2, CO2, CO, CAr, CHe, CH, CM, WM, T):
Severity: Major
Found in src/poliastro/core/earth_atmosphere/jacchia.py - About 1 hr to fix

    Function _O_and_O2_correction has 11 arguments (exceeds 9 allowed). Consider refactoring.
    Open

    def _O_and_O2_correction(alt, Texo, Z, CN2, CO2, CO, CAr, CHe, CH, CM, WM):
    Severity: Major
    Found in src/poliastro/core/earth_atmosphere/jacchia.py - About 45 mins to fix

      Function _H_correction has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      def _H_correction(alt, Texo, x, y, Z, CN2, CO2, CO, CAr, CHe, CH, CM, WM, T):
          phid00 = 10.0 ** (6.9 + 28.9 * Texo ** (-0.25)) / 2.0e20
          phid00 = phid00 * 5.24e2
          H_500 = 10.0 ** (-0.06 + 28.9 * Texo ** (-0.25))
          # print(alt)
      Severity: Minor
      Found in src/poliastro/core/earth_atmosphere/jacchia.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status