poliastro/poliastro

View on GitHub
src/poliastro/core/iod.py

Summary

Maintainability
B
6 hrs
Test Coverage

File iod.py has 329 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import numpy as np
from numpy import pi

from poliastro.core.hyper import hyp2f1b
from poliastro.core.stumpff import c2, c3
Severity: Minor
Found in src/poliastro/core/iod.py - About 3 hrs to fix

    Cyclomatic complexity is too high in function vallado. (8)
    Open

    @jit
    def vallado(k, r0, r, tof, short, numiter, rtol):
        r"""Solves the Lambert's problem.
    
        The algorithm returns the initial velocity vector and the final one, these are
    Severity: Minor
    Found in src/poliastro/core/iod.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Cyclomatic complexity is too high in function _find_xy. (8)
    Open

    @jit
    def _find_xy(ll, T, M, numiter, rtol):
        """Computes all x, y for given number of revolutions.
    
        """
    Severity: Minor
    Found in src/poliastro/core/iod.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Cyclomatic complexity is too high in function izzo. (6)
    Open

    @jit
    def izzo(k, r1, r2, tof, M, numiter, rtol):
        """ Aplies izzo algorithm to solve Lambert's problem.
    
        Parameters
    Severity: Minor
    Found in src/poliastro/core/iod.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Function vallado has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    def vallado(k, r0, r, tof, short, numiter, rtol):
        r"""Solves the Lambert's problem.
    
        The algorithm returns the initial velocity vector and the final one, these are
        computed by the following expresions:
    Severity: Minor
    Found in src/poliastro/core/iod.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _initial_guess has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def _initial_guess(T, ll, M):
        """Initial guess.
    
        """
        if M == 0:
    Severity: Minor
    Found in src/poliastro/core/iod.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _find_xy has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def _find_xy(ll, T, M, numiter, rtol):
        """Computes all x, y for given number of revolutions.
    
        """
        # For abs(ll) == 1 the derivative is not continuous
    Severity: Minor
    Found in src/poliastro/core/iod.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    TODO found
    Open

        # TODO: What about derivatives when x approaches 1?
    Severity: Minor
    Found in src/poliastro/core/iod.py by fixme

    There are no issues that match your filters.

    Category
    Status