# poliastro/poliastro

src/poliastro/core/propagation.py

### Summary

D
2 days

#### File `propagation.py` has 743 lines of code (exceeds 250 allowed). Consider refactoring. Open

``````import numpy as np

from poliastro.core.angles import (
D_to_nu,
E_to_nu,``````
Found in src/poliastro/core/propagation.py - About 1 day to fix

#### Function `pimienta` has 95 lines of code (exceeds 25 allowed). Consider refactoring. Open

``````def pimienta(k, r0, v0, tof):
""" Raw algorithm for Adonis' Pimienta and John L. Crassidis 15th order
polynomial Kepler solver.

Parameters``````
Found in src/poliastro/core/propagation.py - About 3 hrs to fix

#### Cyclomatic complexity is too high in function danby. (7) Open

``````@jit
def danby(k, r0, v0, tof, numiter=20, rtol=1e-8):
""" Kepler solver for both elliptic and parabolic orbits based on Danby's
algorithm.

``````

## Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

#### Cyclomatic complexity is too high in function mikkola. (7) Open

``````@jit
def mikkola(k, r0, v0, tof, rtol=None):
""" Raw algorithm for Mikkola's Kepler solver.

Parameters``````

## Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

#### Cyclomatic complexity is too high in function kepler. (6) Open

``````@jit
def kepler(k, r0, v0, tof, numiter):
r"""Solves Kepler's Equation by applying a Newton-Raphson method.

If the position of a body along its orbit wants to be computed``````

## Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

#### Function `danby` has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open

``````def danby(k, r0, v0, tof, numiter=20, rtol=1e-8):
""" Kepler solver for both elliptic and parabolic orbits based on Danby's
algorithm.

Parameters``````
Found in src/poliastro/core/propagation.py - About 1 hr to fix

# Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

### A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

#### Function `mikkola` has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open

``````def mikkola(k, r0, v0, tof, rtol=None):
""" Raw algorithm for Mikkola's Kepler solver.

Parameters
----------``````
Found in src/poliastro/core/propagation.py - About 1 hr to fix

# Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

### A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

#### Function `kepler` has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open

``````def kepler(k, r0, v0, tof, numiter):
r"""Solves Kepler's Equation by applying a Newton-Raphson method.

If the position of a body along its orbit wants to be computed
for an specific time, it can be solved by terms of the Kepler's Equation:``````
Found in src/poliastro/core/propagation.py - About 45 mins to fix

# Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

### A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

#### TODO found Open

``    # TODO: implement hyperbolic case``
Found in src/poliastro/core/propagation.py by fixme

#### TODO found Open

``    # TODO: parabolic and hyperbolic not implemented cases``
Found in src/poliastro/core/propagation.py by fixme