poliastro/poliastro

View on GitHub
src/poliastro/core/propagation/__init__.py

Summary

Maintainability
D
2 days
Test Coverage

File __init__.py has 754 lines of code (exceeds 350 allowed). Consider refactoring.
Open

""" Low level propagation algorithms """

import numpy as np

from .._jit import jit
Severity: Major
Found in src/poliastro/core/propagation/__init__.py - About 1 day to fix

    Function pimienta_coe has 92 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def pimienta_coe(k, p, ecc, inc, raan, argp, nu, tof):
    
        q = p / (1 + ecc)
    
        # TODO: Do something to increase parabolic accuracy?
    Severity: Major
    Found in src/poliastro/core/propagation/__init__.py - About 3 hrs to fix

      Cyclomatic complexity is too high in function danby_coe. (8)
      Open

      @jit
      def danby_coe(k, p, ecc, inc, raan, argp, nu, tof, numiter=20, rtol=1e-8):
      
          semi_axis_a = p / (1 - ecc ** 2)
          n = np.sqrt(k / np.abs(semi_axis_a) ** 3)

      Cyclomatic Complexity

      Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

      Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

      Construct Effect on CC Reasoning
      if +1 An if statement is a single decision.
      elif +1 The elif statement adds another decision.
      else +0 The else statement does not cause a new decision. The decision is at the if.
      for +1 There is a decision at the start of the loop.
      while +1 There is a decision at the while statement.
      except +1 Each except branch adds a new conditional path of execution.
      finally +0 The finally block is unconditionally executed.
      with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
      assert +1 The assert statement internally roughly equals a conditional statement.
      Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
      Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

      Source: http://radon.readthedocs.org/en/latest/intro.html

      Cyclomatic complexity is too high in function mikkola_coe. (7)
      Open

      @jit
      def mikkola_coe(k, p, ecc, inc, raan, argp, nu, tof):
      
          a = p / (1 - ecc ** 2)
          n = np.sqrt(k / np.abs(a) ** 3)

      Cyclomatic Complexity

      Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

      Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

      Construct Effect on CC Reasoning
      if +1 An if statement is a single decision.
      elif +1 The elif statement adds another decision.
      else +0 The else statement does not cause a new decision. The decision is at the if.
      for +1 There is a decision at the start of the loop.
      while +1 There is a decision at the while statement.
      except +1 Each except branch adds a new conditional path of execution.
      finally +0 The finally block is unconditionally executed.
      with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
      assert +1 The assert statement internally roughly equals a conditional statement.
      Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
      Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

      Source: http://radon.readthedocs.org/en/latest/intro.html

      Function danby_coe has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

      def danby_coe(k, p, ecc, inc, raan, argp, nu, tof, numiter=20, rtol=1e-8):
      
          semi_axis_a = p / (1 - ecc ** 2)
          n = np.sqrt(k / np.abs(semi_axis_a) ** 3)
      
      
      Severity: Minor
      Found in src/poliastro/core/propagation/__init__.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Cyclomatic complexity is too high in function vallado. (6)
      Open

      @jit
      def vallado(k, r0, v0, tof, numiter):
          r"""Solves Kepler's Equation by applying a Newton-Raphson method.
      
          If the position of a body along its orbit wants to be computed

      Cyclomatic Complexity

      Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

      Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

      Construct Effect on CC Reasoning
      if +1 An if statement is a single decision.
      elif +1 The elif statement adds another decision.
      else +0 The else statement does not cause a new decision. The decision is at the if.
      for +1 There is a decision at the start of the loop.
      while +1 There is a decision at the while statement.
      except +1 Each except branch adds a new conditional path of execution.
      finally +0 The finally block is unconditionally executed.
      with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
      assert +1 The assert statement internally roughly equals a conditional statement.
      Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
      Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

      Source: http://radon.readthedocs.org/en/latest/intro.html

      Function mikkola_coe has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

      def mikkola_coe(k, p, ecc, inc, raan, argp, nu, tof):
      
          a = p / (1 - ecc ** 2)
          n = np.sqrt(k / np.abs(a) ** 3)
      
      
      Severity: Minor
      Found in src/poliastro/core/propagation/__init__.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function vallado has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      def vallado(k, r0, v0, tof, numiter):
          r"""Solves Kepler's Equation by applying a Newton-Raphson method.
      
          If the position of a body along its orbit wants to be computed
          for an specific time, it can be solved by terms of the Kepler's Equation:
      Severity: Minor
      Found in src/poliastro/core/propagation/__init__.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function danby_coe has 10 arguments (exceeds 9 allowed). Consider refactoring.
      Open

      def danby_coe(k, p, ecc, inc, raan, argp, nu, tof, numiter=20, rtol=1e-8):
      Severity: Major
      Found in src/poliastro/core/propagation/__init__.py - About 35 mins to fix

        Function gooding_coe has 10 arguments (exceeds 9 allowed). Consider refactoring.
        Open

        def gooding_coe(k, p, ecc, inc, raan, argp, nu, tof, numiter=150, rtol=1e-8):
        Severity: Major
        Found in src/poliastro/core/propagation/__init__.py - About 35 mins to fix

          TODO found
          Open

              # TODO: parabolic and hyperbolic not implemented cases

          TODO found
          Open

              # TODO: Do something to increase parabolic accuracy?

          TODO found
          Open

              # TODO: implement hyperbolic case

          There are no issues that match your filters.

          Category
          Status