Sign upLogin

polkadot-js/api

View on GitHub
Star
packages/types-codec/src/utils/sortValues.ts

Summary

Maintainability
A
3 hrs
Test Coverage

Function sortAsc has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

export function sortAsc<V extends SortArg = Codec> (a: V, b: V): number {
  if (isNumberLike(a) && isNumberLike(b)) {
    return bnToBn(a).cmp(bnToBn(b));
  } else if (a instanceof Map && b instanceof Map) {
    return sortAsc(Array.from(a.values()), Array.from(b.values()));
Severity: Minor
Found in packages/types-codec/src/utils/sortValues.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

    return sortArray(a, b);
Severity: Major
Found in packages/types-codec/src/utils/sortValues.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return sortAsc(a.toU8a(true), b.toU8a(true));
    Severity: Major
    Found in packages/types-codec/src/utils/sortValues.ts - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status