View on GitHub


1 hr
Test Coverage

Function sortAsc has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.

export function sortAsc<V extends SortArg = Codec> (a: V, b: V): number {
  if (isNumberLike(a) && isNumberLike(b)) {
    return bnToBn(a).cmp(bnToBn(b));
  } else if (a instanceof Map && b instanceof Map) {
    return sortAsc(Array.from(a.values()), Array.from(b.values()));
Severity: Minor
Found in packages/types/src/codec/utils/sortValues.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.

    return sortAsc(a.toU8a(true), b.toU8a(true));
Severity: Major
Found in packages/types/src/codec/utils/sortValues.ts - About 30 mins to fix

    There are no issues that match your filters.