Sign upLogin

prakhar1989/react-tags

View on GitHub
Star
src/components/ReactTags.js

Summary

Maintainability
D
2 days
Test Coverage
B
88%

File ReactTags.js has 540 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React, { Component, createRef } from 'react';
import { DndProvider } from 'react-dnd';
import { HTML5Backend } from 'react-dnd-html5-backend';
import isEqual from 'lodash/isEqual';
import noop from 'lodash/noop';
Severity: Major
Found in src/components/ReactTags.js - About 1 day to fix

    Function render has 102 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      render() {
    const tagItems = this.getTagItems();
    const classNames = { ...DEFAULT_CLASSNAMES, ...this.props.classNames };

    // get the suggestions for the given query
    Severity: Major
    Found in src/components/ReactTags.js - About 4 hrs to fix

      ReactTags has 22 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class ReactTags extends Component {
  static propTypes = {
    placeholder: PropTypes.string,
    labelField: PropTypes.string,
    suggestions: PropTypes.arrayOf(
      Severity: Minor
      Found in src/components/ReactTags.js - About 2 hrs to fix

        Function handleKeyDown has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
        Open

          handleKeyDown(e) {
    const { query, selectedIndex, suggestions, selectionMode } = this.state;

    // hide suggestions menu on escape
    if (e.keyCode === KEYS.ESCAPE) {
        Severity: Minor
        Found in src/components/ReactTags.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function handleKeyDown has 48 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          handleKeyDown(e) {
    const { query, selectedIndex, suggestions, selectionMode } = this.state;

    // hide suggestions menu on escape
    if (e.keyCode === KEYS.ESCAPE) {
        Severity: Minor
        Found in src/components/ReactTags.js - About 1 hr to fix

          Function handleDelete has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            handleDelete(index, event) {
    event.preventDefault();
    event.stopPropagation();
    const currentTags = this.props.tags.slice();
    // Early exit from the function if the array
          Severity: Minor
          Found in src/components/ReactTags.js - About 1 hr to fix

            Function constructor has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              constructor(props) {
    super(props);

    if (!props.inline) {
      /* eslint-disable no-console */
            Severity: Minor
            Found in src/components/ReactTags.js - About 1 hr to fix

              Function handleDelete has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                handleDelete(index, event) {
    event.preventDefault();
    event.stopPropagation();
    const currentTags = this.props.tags.slice();
    // Early exit from the function if the array
              Severity: Minor
              Found in src/components/ReactTags.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  if (this.tagLimitReached()) {
      this.setState({ error: ERRORS.TAG_LIMIT });
      this.resetAndFocusInput();
      return;
    }
              Severity: Minor
              Found in src/components/ReactTags.js and 1 other location - About 35 mins to fix
              src/components/ReactTags.js on lines 391..395

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                    if (this.tagLimitReached()) {
        this.setState({ error: ERRORS.TAG_LIMIT });
        this.resetAndFocusInput();
        return;
      }
              Severity: Minor
              Found in src/components/ReactTags.js and 1 other location - About 35 mins to fix
              src/components/ReactTags.js on lines 355..359

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status