Sign upLogin

prebid/Prebid.js

View on GitHub
Star
modules/orbitsoftBidAdapter.js

Summary

Maintainability
C
1 day
Test Coverage

Function buildRequests has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

  buildRequests: function (validBidRequests) {
    let bidRequest;
    let serverRequests = [];
    for (let i = 0; i < validBidRequests.length; i++) {
      bidRequest = validBidRequests[i];
Severity: Minor
Found in modules/orbitsoftBidAdapter.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function buildRequests has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  buildRequests: function (validBidRequests) {
    let bidRequest;
    let serverRequests = [];
    for (let i = 0; i < validBidRequests.length; i++) {
      bidRequest = validBidRequests[i];
Severity: Major
Found in modules/orbitsoftBidAdapter.js - About 2 hrs to fix

    Function interpretResponse has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      interpretResponse: function (serverResponse, request) {
    let bidResponses = [];
    if (!serverResponse || serverResponse.error) {
      utils.logError(BIDDER_CODE + ': Server response error');
      return bidResponses;
    Severity: Minor
    Found in modules/orbitsoftBidAdapter.js - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                  if (currentStyle.hasOwnProperty(field)) {
              let styleField = styleParamsMap[currentValue + '.' + field];
              if (typeof styleField !== 'undefined') {
                stylesParamsArray[styleField] = currentStyle[field];
              }
      Severity: Major
      Found in modules/orbitsoftBidAdapter.js - About 45 mins to fix

        Function interpretResponse has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          interpretResponse: function (serverResponse, request) {
    let bidResponses = [];
    if (!serverResponse || serverResponse.error) {
      utils.logError(BIDDER_CODE + ': Server response error');
      return bidResponses;
        Severity: Minor
        Found in modules/orbitsoftBidAdapter.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status