presidentbeef/brakeman

View on GitHub
lib/brakeman/checks/check_redirect.rb

Summary

Maintainability
A
3 hrs
Test Coverage
A
98%

Consider simplifying this complex logical expression.
Open

    if method == :redirect_to and
        not only_path?(call) and
        not explicit_host?(opt) and
        not slice_call?(opt) and
        not safe_permit?(opt) and
Severity: Major
Found in lib/brakeman/checks/check_redirect.rb - About 40 mins to fix

    Consider simplifying this complex logical expression.
    Open

        if node_type? exp, :or
          decorated_model? exp.lhs or decorated_model? exp.rhs
        else
          tracker.config.has_gem? :draper and
          call? exp and
    Severity: Major
    Found in lib/brakeman/checks/check_redirect.rb - About 40 mins to fix

      Avoid too many return statements within this method.
      Open

              return Match.new(immediate, arg.target)
      Severity: Major
      Found in lib/brakeman/checks/check_redirect.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return Match.new(immediate, arg)
        Severity: Major
        Found in lib/brakeman/checks/check_redirect.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return false
          Severity: Major
          Found in lib/brakeman/checks/check_redirect.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                  return Match.new(immediate, arg)
            Severity: Major
            Found in lib/brakeman/checks/check_redirect.rb - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    if res.type == :immediate
                      confidence = :high
                    else
                      confidence = :weak
                    end
              Severity: Minor
              Found in lib/brakeman/checks/check_redirect.rb and 1 other location - About 15 mins to fix
              lib/brakeman/checks/check_execute.rb on lines 64..77

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 26.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status