propelorm/Propel2

View on GitHub

Showing 740 of 740 total issues

File MysqlPlatform.php has 612 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * MIT License. This file is part of the Propel package.
 * For the full copyright and license information, please view the LICENSE
Severity: Major
Found in src/Propel/Generator/Platform/MysqlPlatform.php - About 1 day to fix

    Function startElement has a Cognitive Complexity of 67 (exceeds 5 allowed). Consider refactoring.
    Open

        public function startElement($parser, string $tagName, array $attributes): void
        {
            $parentTag = $this->peekCurrentSchemaTag();
            if ($parentTag === false) {
                switch ($tagName) {
    Severity: Minor
    Found in src/Propel/Generator/Builder/Util/SchemaReader.php - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File AbstractOMBuilder.php has 603 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    /**
     * MIT License. This file is part of the Propel package.
     * For the full copyright and license information, please view the LICENSE
    Severity: Major
    Found in src/Propel/Generator/Builder/Om/AbstractOMBuilder.php - About 1 day to fix

      File NestedSetBehaviorQueryBuilderModifier.php has 603 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
      
      /**
       * MIT License. This file is part of the Propel package.
       * For the full copyright and license information, please view the LICENSE

        TableDiff has 69 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class TableDiff
        {
            /**
             * The first Table object.
             *
        Severity: Major
        Found in src/Propel/Generator/Model/Diff/TableDiff.php - About 1 day to fix

          ForeignKey has 68 functions (exceeds 20 allowed). Consider refactoring.
          Open

          class ForeignKey extends MappingModel
          {
              /**
               * These constants are the uppercase equivalents of the onDelete / onUpdate
               * values in the schema definition.
          Severity: Major
          Found in src/Propel/Generator/Model/ForeignKey.php - About 1 day to fix

            File PgsqlPlatform.php has 569 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
            
            /**
             * MIT License. This file is part of the Propel package.
             * For the full copyright and license information, please view the LICENSE
            Severity: Major
            Found in src/Propel/Generator/Platform/PgsqlPlatform.php - About 1 day to fix

              Function execute has a Cognitive Complexity of 61 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function execute(InputInterface $input, OutputInterface $output): int
                  {
                      $configOptions = [];
              
                      if ($this->hasInputOption('output-dir', $input)) {
              Severity: Minor
              Found in src/Propel/Generator/Command/MigrationMigrateCommand.php - About 1 day to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Database has 59 functions (exceeds 20 allowed). Consider refactoring.
              Open

              class Database extends ScopedMappingModel
              {
                  use BehaviorableTrait;
              
                  /**
              Severity: Major
              Found in src/Propel/Generator/Model/Database.php - About 1 day to fix

                File TableDiff.php has 518 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                <?php
                
                /**
                 * MIT License. This file is part of the Propel package.
                 * For the full copyright and license information, please view the LICENSE
                Severity: Major
                Found in src/Propel/Generator/Model/Diff/TableDiff.php - About 1 day to fix

                  File ForeignKey.php has 516 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  <?php
                  
                  /**
                   * MIT License. This file is part of the Propel package.
                   * For the full copyright and license information, please view the LICENSE
                  Severity: Major
                  Found in src/Propel/Generator/Model/ForeignKey.php - About 1 day to fix

                    NestedSetBehaviorObjectBuilderModifier has 58 functions (exceeds 20 allowed). Consider refactoring.
                    Open

                    class NestedSetBehaviorObjectBuilderModifier
                    {
                        /**
                         * @var \Propel\Generator\Behavior\NestedSet\NestedSetBehavior
                         */

                      File Database.php has 513 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      <?php
                      
                      /**
                       * MIT License. This file is part of the Propel package.
                       * For the full copyright and license information, please view the LICENSE
                      Severity: Major
                      Found in src/Propel/Generator/Model/Database.php - About 1 day to fix

                        File SortableBehaviorObjectBuilderModifier.php has 512 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        <?php
                        
                        /**
                         * MIT License. This file is part of the Propel package.
                         * For the full copyright and license information, please view the LICENSE

                          File VersionableBehaviorObjectBuilderModifier.php has 512 lines of code (exceeds 250 allowed). Consider refactoring.
                          Open

                          <?php
                          
                          /**
                           * MIT License. This file is part of the Propel package.
                           * For the full copyright and license information, please view the LICENSE

                            Function execute has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
                            Open

                                protected function execute(InputInterface $input, OutputInterface $output): int
                                {
                                    $configOptions = [];
                            
                                    if ($this->hasInputOption('connection', $input)) {
                            Severity: Minor
                            Found in src/Propel/Generator/Command/MigrationDiffCommand.php - About 7 hrs to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function isUnique has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function isUnique(array $keys): bool
                                {
                                    if (count($keys) === 1) {
                                        $column = $keys[0] instanceof Column ? $keys[0] : $this->getColumn($keys[0]);
                                        if ($column) {
                            Severity: Minor
                            Found in src/Propel/Generator/Model/Table.php - About 7 hrs to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            QueryBuilder has 55 functions (exceeds 20 allowed). Consider refactoring.
                            Open

                            class QueryBuilder extends AbstractOMBuilder
                            {
                                /**
                                 * Returns the package for the [base] object classes.
                                 *
                            Severity: Major
                            Found in src/Propel/Generator/Builder/Om/QueryBuilder.php - About 7 hrs to fix

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                  private static $sqliteTypeMap = [
                                      'tinyint' => PropelTypes::TINYINT,
                                      'smallint' => PropelTypes::SMALLINT,
                                      'mediumint' => PropelTypes::SMALLINT,
                                      'int' => PropelTypes::INTEGER,
                              Severity: Major
                              Found in src/Propel/Generator/Reverse/SqliteSchemaParser.php and 1 other location - About 7 hrs to fix
                              src/Propel/Generator/Reverse/MysqlSchemaParser.php on lines 40..70

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 239.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                  private static $mysqlTypeMap = [
                                      'tinyint' => PropelTypes::TINYINT,
                                      'smallint' => PropelTypes::SMALLINT,
                                      'mediumint' => PropelTypes::SMALLINT,
                                      'int' => PropelTypes::INTEGER,
                              Severity: Major
                              Found in src/Propel/Generator/Reverse/MysqlSchemaParser.php and 1 other location - About 7 hrs to fix
                              src/Propel/Generator/Reverse/SqliteSchemaParser.php on lines 41..71

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 239.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Severity
                              Category
                              Status
                              Source
                              Language